Throw MappingException if owning/inverse side of refs are missing targetDocument

lib/Doctrine/ODM/MongoDB/Mapping/ClassMetadataInfo.php

@@ -1149,6 +1149,11 @@ public function mapField(array $mapping)
         if (isset($mapping['reference']) && ! empty($mapping['simple']) && ! isset($mapping['targetDocument'])) {
             throw MappingException::simpleReferenceRequiresTargetDocument($this->name, $mapping['fieldName']);
         }
+
+        if (isset($mapping['reference']) && empty($mapping['targetDocument']) && empty($mapping['discriminatorMap']) &&
+                (isset($mapping['mappedBy']) || isset($mapping['inversedBy']))) {
+            throw MappingException::owningAndInverseReferencesRequireTargetDocument($this->name, $mapping['fieldName']);
+        }
 
         if ($this->isEmbeddedDocument && isset($mapping['strategy']) &&
                 ($mapping['strategy'] === 'atomicSet' || $mapping['strategy'] === 'atomicSetArray')) {

lib/Doctrine/ODM/MongoDB/Mapping/MappingException.php

@@ -173,9 +173,25 @@ public static function simpleReferenceRequiresTargetDocument($className, $fieldN
     {
         return new self("Target document must be specified for simple reference: $className::$fieldName");
     }
-
+
+    /**
+     * @param string $strategy
+     * @param string $className
+     * @param string $fieldName
+     * @return MappingException
+     */
     public static function atomicCollectionStrategyNotAllowed($strategy, $className, $fieldName)
     {
         return new self("$strategy collection strategy can be used only in top level document, used in $className::$fieldName");
     }
+
+    /**
+     * @param string $className
+     * @param string $fieldName
+     * @return MappingException
+     */
+    public static function owningAndInverseReferencesRequireTargetDocument($className, $fieldName)
+    {
+        return new self("Target document must be specified for owning/inverse sides of reference: $className::$fieldName");
+    }
 }

tests/Doctrine/ODM/MongoDB/Tests/Mapping/ClassMetadataInfoTest.php

@@ -251,6 +251,33 @@ public function testAtomicCollectionUpdateUsageInEmbeddedDocument()
             'strategy' => 'atomicSet',
         ));
     }
+
+    /**
+     * @dataProvider provideOwningAndInversedRefsNeedTargetDocument
+     * @expectedException \Doctrine\ODM\MongoDB\Mapping\MappingException
+     */
+    public function testOwningAndInversedRefsNeedTargetDocument($config)
+    {
+        $config = array_merge($config, array(
+            'fieldName' => 'many',
+            'reference' => true,
+            'strategy' => 'atomicSet',
+        ));
+
+        $cm = new ClassMetadataInfo('stdClass');
+        $cm->isEmbeddedDocument = true;
+        $cm->mapField($config);
+    }
+
+    public function provideOwningAndInversedRefsNeedTargetDocument()
+    {
+        return array(
+            array(array('type' => 'one', 'mappedBy' => 'post')),
+            array(array('type' => 'one', 'inversedBy' => 'post')),
+            array(array('type' => 'many', 'mappedBy' => 'post')),
+            array(array('type' => 'many', 'inversedBy' => 'post')),
+        );
+    }
 }
 
 class TestCustomRepositoryClass extends DocumentRepository

tests/Doctrine/ODM/MongoDB/Tests/Mapping/ClassMetadataTest.php

@@ -67,11 +67,11 @@ public function testClassMetadataInstanceSerialization()
     public function testOwningSideAndInverseSide()
     {
         $cm = new ClassMetadataInfo('Documents\User');
-        $cm->mapManyReference(array('fieldName' => 'articles', 'inversedBy' => 'user'));
+        $cm->mapManyReference(array('fieldName' => 'articles', 'targetDocument' => 'Documents\Article', 'inversedBy' => 'user'));
         $this->assertTrue($cm->fieldMappings['articles']['isOwningSide']);
 
         $cm = new ClassMetadataInfo('Documents\Article');
-        $cm->mapOneReference(array('fieldName' => 'user', 'mappedBy' => 'articles'));
+        $cm->mapOneReference(array('fieldName' => 'user', 'targetDocument' => 'Documents\User', 'mappedBy' => 'articles'));
         $this->assertTrue($cm->fieldMappings['user']['isInverseSide']);
     }