Added support for dates with milliseconds #1063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param mixed $value \DateTime|\MongoDate|int|float | ||
| * @return \DateTime | ||
| */ | ||
| public static function getDateTime($value) |
There was a problem hiding this comment.
The DateTime conversion is getting too heavy to nice fit in the "closures" and there would be too much code duplication otherwise, hence the public static function. I am open to alternatives.
|
The Travis issues are related to truncation, I would need to address them. |
|
I decided to remove tests for truncation because Mongo is not consistent across its version. I could have enforce the truncation in PHP, but it would significantly slow the process and I don’t think it’s worth it, microseconds should not matter to end user anyway since Mongo doesn’t support it. |
|
Travis errors now unrelated, good to merge. |
|
|
jwage
added a commit
that referenced
this pull request
Mar 28, 2015
Added support for dates with milliseconds
|
Are you Jesus? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1061
Affects #1060 : now will overflow and the loaded date will be in 2036. Note that problem only appears when saving to and loading from Mongo, not when simply converting values.
Duplicate of #1028 (sorry, didn’t see).
Microseconds passed as MongoDate, DateTime, float or DateTime string (
'2000-01-01 00:00:00.123') are all handled.