spl_object_hash collisions

[tecbot]

Hi, today we run in an crazy issue, We found that is releated to an issue which was already reported at doctrine ORM: http://www.doctrine-project.org/jira/browse/DDC-1896

In our case, we run a Behat test of one of our features and all the time PHP returns a hash for a new document which was already used of an embedded document previously. So doctrine thinks that the document is already managed and don't insert it into our database. Only a clear between this operations helps us to prevent this issue.

IMHO we should make the document state behaviour a little bit more robust and shouldn't check only the spl object hash of a document. By the way the documents are not of the same type.

[henrikbjorn]

This is mentioned on the php documentation http://dk1.php.net/spl_object_hash. "When an object is destroyed, its hash may be reused for other objects."

[tecbot]

@henrikbjorn Exactly, this is why we should change it to a robust solution.

[jmikola]

@beberlei: If I understand your response in DDC-1896 correctly, calling clear() is the only advisable solution in this case, correct?

Even if we incorporated some other factor into the hash used to track documents in UnitOfWork (e.g. it's class name), that won't be fool-proof. SplObjectStorage would be an ideal solution if only it was performant enough.

[AronSzigetvari]

We have also found the same issue, I have opened a ticket, too: #1017 and made a pull request (#1023 ) but there was no reaction to it, so I don't know if and when it will be merged.
This solved the issue in our project.

[malarzm]

This is fixed in 1.0.0 by #782

[AronSzigetvari]

Augusztus 10 és 19 között szabadságon leszek, legközelebb augusztus 24-én, hétfőn olvasom a leveleimet. Sürgős esetben kérem hívja a 398-0468-as telefonszámot.

Üdvözlettel:
Szigetvári Áron
vezető fejlesztő