Skip to content

Conversation

@morozov
Copy link
Member

@morozov morozov commented Aug 29, 2025

Integration with AppVeyor was originally implemented in #2617. This effort started in Jan 2017. At that time there was no CI for SQL Server in the DBAL project at all. Testing with SQL Server on Linux was added in #3050 (Mar 2018).

Why remove it

  1. Builds on AppVeyor require maintenance. Despite the effort put into Fix PHP 8.4 installation on AppVeyor #7114 and Unconditionally update vcredist140 on AppVeyor #7117, the build still fails.
  2. Oftentimes, AppVeyor is the slowest part of the build (it allows only one concurrent build).
  3. There is no Windows-specific code in the source directory, so this won't impact test coverage.
  4. I don't remember a single issue with SQL Server that would be found on AppVeyor or reproducible only on Windows.

@morozov morozov added this to the 3.10.2 milestone Aug 29, 2025
@morozov morozov requested review from derrabus and greg0ire August 29, 2025 04:52
Copy link
Member

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good riddance

@morozov morozov merged commit 1a3c76a into doctrine:3.10.x Aug 29, 2025
@morozov morozov deleted the remove-appveyor branch August 29, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants