Skip to content

Leverage the new PDO subclasses #6532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2024
Merged

Leverage the new PDO subclasses #6532

merged 1 commit into from
Oct 10, 2024
+117 −6

Conversation

@derrabus
Copy link
Member

@derrabus derrabus commented Oct 9, 2024 •
edited
Loading

Q A
Type feature
Fixed issues N/A

Summary

This PR adds support for the new PDO subclasses to DBAL.

TODO:

@derrabus derrabus requested review from greg0ire and morozov October 9, 2024 08:18
@derrabus derrabus force-pushed the feature/pdo-subclasses branch from 6a8f2b1 to 0343ecc Compare October 9, 2024 11:19
@derrabus derrabus closed this Oct 9, 2024
@derrabus derrabus reopened this Oct 9, 2024
@derrabus derrabus force-pushed the feature/pdo-subclasses branch 2 times, most recently from 2e8db90 to c8eecae Compare October 10, 2024 09:22
greg0ire
greg0ire previously approved these changes Oct 10, 2024
View reviewed changes
@derrabus derrabus marked this pull request as ready for review October 10, 2024 09:33
@derrabus
Copy link
Member Author

I'm working around the PHP bug for the time being. If we try to open a persistent connection, I'm falling back to the old constructor.

@derrabus derrabus force-pushed the feature/pdo-subclasses branch from c8eecae to 3cb79ff Compare October 10, 2024 09:43
@derrabus derrabus added this to the 4.2.0 milestone Oct 10, 2024
@greg0ire
Copy link
Member

Oh, a new codecov error: codecov/codecov-action#1580

@derrabus derrabus merged commit 54be50e into doctrine:4.2.x Oct 10, 2024
88 of 89 checks passed
@derrabus derrabus deleted the feature/pdo-subclasses branch October 10, 2024 12:06
derrabus added a commit to derrabus/dbal that referenced this pull request Oct 10, 2024
@derrabus
Merge branch '4.2.x' into 5.0.x
ef19927 
* 4.2.x:
  Implement an EnumType for MySQL/MariaDB (doctrine#6536)
  Leverage the new PDO subclasses (doctrine#6532)
  PHPStan 1.12.6 (doctrine#6535)
@derrabus derrabus mentioned this pull request Nov 24, 2024
Merged
This was referenced Sep 4, 2025
Merged
Merged
derrabus added a commit that referenced this pull request Sep 4, 2025
@derrabus
Document the PDO subclasses backport (#7137)
3e46b11 
|      Q       |   A
|------------- | -----------
| Type         | documentation
| Fixed issues | N/A

#### Summary

Deprecations introduced with PHP 8.5 forced us to backport #6532 as
#7132. In this PR, I'm also backporting the entry from our UPGRADE.md
documentation.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@morozov morozov morozov approved these changes

@greg0ire greg0ire greg0ire approved these changes

+1 more reviewer

@GromNaN GromNaN GromNaN approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Connecting Connections New Feature PDO

Projects

None yet

Milestone

4.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@derrabus @greg0ire @morozov @GromNaN