Additional changes based on the discussion in #4007

[morozov]

Q	A
Type	bug/improvement
BC Break	yes/no
Fixed issues	#4033

1. Backport the documentation changes as suggested in Replace the concept of statement fetch modes with the explicit API #4007 (comment).
2. Backport the fix for the issue discovered in Replace the concept of statement fetch modes with the explicit API #4007 (comment) and the corresponding changes in the tests that cover the issue.
3. Fix ResultCacheStatement::fetchAll() doesn't respect fetch mode on subsequent calls #4033 since it prevents the refactored tests from passing on 2.x.

[morozov]

This is the root cause of #4033.

[morozov]

This is how #4033 was discovered.

[greg0ire]

Feel free to ignore my suggestion and merge, it's nothing important.

[greg0ire]

How about this:

Suggested change

	if ($fetchMode === FetchMode::NUMERIC) {
	foreach ($data as $i => $row) {
	$data[$i] = array_values($row);
	}
	} elseif ($fetchMode === FetchMode::MIXED) {
	foreach ($data as $i => $row) {
	$data[$i] = array_merge($row, array_values($row));
	}
	} elseif ($fetchMode === FetchMode::COLUMN) {
	foreach ($data as $i => $row) {
	$data[$i] = reset($row);
	}
	}
	return $data;
	return array_map(function(array $row) use ($fetchMode) {
	switch ($fetchMode)
	{
	case FetchMode::NUMERIC:
	return array_values($row);
	case FetchMode::MIXED:
	return array_merge($row, array_values($row));
	case FetchMode::COLUMN:
	return reset($row);
	default:
	return $row;
	}
	}, $data);

?

[morozov]

It will require a switch on each row instead of an if/else once.