Refactor FK exception tests

[BenMorel]

Q	A
Type	improvement
BC Break	no
Fixed issues	none

Summary

Several tests can be greatly simplified by delegating the tear-down tasks to finally {}, instead of catching and re-throwing exceptions.

This works fine with expectException(), too.

Moved FK exception tests to their own class with proper setUp()/tearDown().

[BenMorel]

Note: the SQL Server failure on Travis seems unrelated to this change:

Doctrine\Tests\DBAL\Functional\Platform\DefaultExpressionTest::testCurrentTimestamp
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'2019-12-30 14:14:15.770000'
+'2019-12-30 14:14:15.766667'

Should I force push the previous commit to restart the build?

[morozov]

Would it make more sense to extract this test to a separate class and let PHPUnit take care of calling it? Or just make this routine part of the shared teardown? Calling it manually and having flow control logic in a test still smells.

[BenMorel]

It does smell, but smells less than before! ;-) That's a good point, though. Moved to their own class with proper setUp()/tearDown() in da3a944.

[SenseException]

A rebase is probably needed before this can be merged.

[BenMorel]

Rebased & squashed!

[morozov]

Thanks @BenMorel!