Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proper types to Doctrine\DBAL\Tools namespace. #3570

Merged
merged 1 commit into from
May 30, 2019
Merged

Add proper types to Doctrine\DBAL\Tools namespace. #3570

merged 1 commit into from
May 30, 2019

Conversation

jwage
Copy link
Member

@jwage jwage commented May 30, 2019

Q A
Type improvement
BC Break no

Summary

Add proper types to Doctrine\DBAL\Tools namespace.

@jwage jwage added this to the 3.0.0 milestone May 30, 2019
@morozov morozov merged commit 4675f61 into doctrine:develop May 30, 2019
@morozov morozov self-assigned this May 30, 2019
@jwage
Copy link
Member Author

jwage commented May 30, 2019

I don't think this one had any BC breaks in it, did it?

@morozov
Copy link
Member

morozov commented May 30, 2019 •
edited
Loading

Formally, it does: public function setKeywordListClass(string $name, string $class) can no longer be called with as setKeywordListClass(1, 2), etc. There are no breaking changes worth mentioning in UPGRADE.md though.

@jwage jwage deleted the tools-types branch May 30, 2019 14:34
morozov added a commit to morozov/dbal that referenced this pull request May 31, 2019
@morozov
Merge pull request doctrine#3570 from jwage/tools-types
0140609 
Add proper types to Doctrine\DBAL\Tools namespace.
morozov added a commit to morozov/dbal that referenced this pull request May 31, 2019
@morozov
Merge pull request doctrine#3570 from jwage/tools-types
43b2149 
Add proper types to Doctrine\DBAL\Tools namespace.
morozov added a commit to morozov/dbal that referenced this pull request May 31, 2019
@morozov
Merge pull request doctrine#3570 from jwage/tools-types
850441d 
Add proper types to Doctrine\DBAL\Tools namespace.
morozov added a commit to morozov/dbal that referenced this pull request May 31, 2019
@morozov
Merge pull request doctrine#3570 from jwage/tools-types
df81a44 
Add proper types to Doctrine\DBAL\Tools namespace.
morozov added a commit that referenced this pull request Jun 13, 2019
@morozov
Merge pull request #3570 from jwage/tools-types
cf99aaf 
Add proper types to Doctrine\DBAL\Tools namespace.
morozov added a commit that referenced this pull request Jun 27, 2019
@morozov
Merge pull request #3570 from jwage/tools-types
c711917 
Add proper types to Doctrine\DBAL\Tools namespace.
morozov added a commit that referenced this pull request Jun 27, 2019
@morozov
Merge pull request #3570 from jwage/tools-types
951a338 
Add proper types to Doctrine\DBAL\Tools namespace.
morozov added a commit that referenced this pull request Jun 27, 2019
@morozov
Merge pull request #3570 from jwage/tools-types
20bbd44 
Add proper types to Doctrine\DBAL\Tools namespace.
morozov added a commit to morozov/dbal that referenced this pull request Aug 26, 2019
@morozov
Merge pull request doctrine#3570 from jwage/tools-types
1602aab 
Add proper types to Doctrine\DBAL\Tools namespace.
morozov added a commit to morozov/dbal that referenced this pull request Aug 26, 2019
@morozov
Merge pull request doctrine#3570 from jwage/tools-types
f925774 
Add proper types to Doctrine\DBAL\Tools namespace.
morozov added a commit to morozov/dbal that referenced this pull request Aug 26, 2019
@morozov
Merge pull request doctrine#3570 from jwage/tools-types
628f271 
Add proper types to Doctrine\DBAL\Tools namespace.
morozov added a commit to morozov/dbal that referenced this pull request Aug 27, 2019
@morozov
Merge pull request doctrine#3570 from jwage/tools-types
65c3cec 
Add proper types to Doctrine\DBAL\Tools namespace.
morozov added a commit that referenced this pull request Nov 2, 2019
@morozov
Merge pull request #3570 from jwage/tools-types
ead0401 
Add proper types to Doctrine\DBAL\Tools namespace.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@morozov morozov morozov approved these changes

@greg0ire greg0ire greg0ire approved these changes

Assignees

@morozov morozov

Labels
BC Break Improvement Strict Typing Tools
Projects
None yet
Milestone
4.0.0-beta1
Development

Successfully merging this pull request may close these issues.
3 participants
@jwage @morozov @greg0ire