-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reworked AbstractPlatform::get*Expression() methods #3498
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
approved these changes
Mar 27, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (besides nits)
This was referenced Mar 27, 2019
Merged
morozov
pushed a commit
that referenced
this pull request
Apr 16, 2019
Reworked AbstractPlatform::get*Expression() methods
morozov
pushed a commit
that referenced
this pull request
May 6, 2019
Reworked AbstractPlatform::get*Expression() methods
morozov
pushed a commit
that referenced
this pull request
May 23, 2019
Reworked AbstractPlatform::get*Expression() methods
morozov
pushed a commit
to morozov/dbal
that referenced
this pull request
May 31, 2019
Reworked AbstractPlatform::get*Expression() methods
morozov
pushed a commit
that referenced
this pull request
Jun 13, 2019
Reworked AbstractPlatform::get*Expression() methods
morozov
pushed a commit
that referenced
this pull request
Jun 27, 2019
Reworked AbstractPlatform::get*Expression() methods
morozov
pushed a commit
that referenced
this pull request
Jun 27, 2019
Reworked AbstractPlatform::get*Expression() methods
morozov
pushed a commit
that referenced
this pull request
Jun 27, 2019
Reworked AbstractPlatform::get*Expression() methods
morozov
pushed a commit
to morozov/dbal
that referenced
this pull request
Aug 26, 2019
Reworked AbstractPlatform::get*Expression() methods
morozov
pushed a commit
that referenced
this pull request
Nov 2, 2019
Reworked AbstractPlatform::get*Expression() methods
This was referenced May 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains the breaking changes in
AbstractPlatform::get*Expression()
methods from #3348.The key changes are:
int
but de-facto accepted an SQL expression are now type-hinted asstring
.$interval
argument of thegetDate(Add|Sub)*Expression()
methods can now accept an SQL expression which makes it possible to define the interval as a numeric literal (former behavior), prepared statement parameter, column name or technically any valid SQL expression 🔥DataAccessTest::testDateArithmetics()
has been reworked into a series of independent tests each of which represents the interval in the query in three modes: numeric literal, prepared statement parameter and an SQL expression.SqlitePlatform::getDateArithmeticIntervalExpression()
, it no longer truncates the time part of the result of addition or subtraction of days, weeks, months, quarters or years. This issue can be filed and fixed additionally inmaster
since it impacts the code portability.