Add Functional test (OCI8Statement)

Author: eisberg

lib/Doctrine/DBAL/Driver/OCI8/OCI8Statement.php

@@ -90,6 +90,19 @@ class OCI8Statement implements IteratorAggregate, Statement
      */
     private $result = false;
 
+    /**
+     * @param resource $dbh The connection handle.
+     *
+     * @return resource
+     */
+    protected function prepareQuery($dbh, string $query)
+    {
+        $stmt = oci_parse($dbh, $query);
+        assert(is_resource($stmt));
+
+        return $stmt;
+    }
+
     /**
      * Creates a new OCI8Statement that uses the given connection handle and SQL statement.
      *
@@ -100,10 +113,7 @@ public function __construct($dbh, string $query, OCI8Connection $conn)
     {
         [$query, $paramMap] = self::convertPositionalToNamedPlaceholders($query);
 
-        $stmt = oci_parse($dbh, $query);
-        assert(is_resource($stmt));
-
-        $this->_sth      = $stmt;
+        $this->_sth      = $this->prepareQuery($dbh, $query);
         $this->_dbh      = $dbh;
         $this->_paramMap = $paramMap;
         $this->_conn     = $conn;
@@ -273,7 +283,7 @@ public function bindValue($param, $value, int $type = ParameterType::STRING) : v
      */
     public function bindParam($param, &$variable, int $type = ParameterType::STRING, ?int $length = null) : void
     {
-        $param = $this->_paramMap[$param] ?? $param;
+        $param = $this->_paramMap[$param] ?? (string) $param;
 
         if ($type === ParameterType::LARGE_OBJECT) {
             $lob = oci_new_descriptor($this->_dbh, OCI_D_LOB);

tests/Doctrine/Tests/DBAL/Functional/Driver/OCI8/StatementTest.php

@@ -39,6 +39,23 @@ public function testQueryConversion(string $query, array $params, array $expecte
         );
     }
 
+    /**
+     * @param mixed[] $params
+     * @param mixed[] $expected
+     *
+     * @dataProvider queryConversionProvider
+     */
+    public function testQueryPrepare(string $query, array $params, array $expected) : void
+    {
+        $stmt = $this->connection->prepare($query);
+        $stmt->execute($params);
+
+        self::assertEquals(
+            $expected,
+            $stmt->fetch()
+        );
+    }
+
     /**
      * @return array<string, array<int, mixed>>
      */
@@ -50,6 +67,11 @@ public static function queryConversionProvider() : iterable
                 [1],
                 ['COL1' => 1],
             ],
+            'named' => [
+                'SELECT :COL COL1 FROM DUAL',
+                [':COL' => 1],
+                ['COL1' => 1],
+            ],
             'literal-with-placeholder' => [
                 "SELECT '?' COL1, ? COL2 FROM DUAL",
                 [2],