Merge pull request #2 from robsonvn/revert-1-master

Revert "Add support for SSL in StreamClient"

Author: robsonvn

.travis.yml

@@ -10,6 +10,7 @@ php:
   - 7.0
 
 before_script:
+  - curl -X PUT localhost:5984/doctrine_test_database
   - composer install
 
 script:

lib/Doctrine/CouchDB/CouchDBClient.php

@@ -122,7 +122,6 @@ static public function create(array $options)
             'path' => null,
             'logging' => false,
             'timeout' => 10,
-            'headers' => array(),
         );
         $options = array_merge($defaults, $options);
 
@@ -140,8 +139,7 @@ static public function create(array $options)
             $options['ip'],
             $options['ssl'],
             $options['path'],
-            $options['timeout'],
-            $options['headers']
+            $options['timeout']
         );
         if ($options['logging'] === true) {
             $connection = new HTTP\LoggingClient($connection);

lib/Doctrine/CouchDB/HTTP/AbstractHTTPClient.php

@@ -30,7 +30,6 @@ abstract class AbstractHTTPClient implements Client
         'username'   => null,
         'password'   => null,
         'path'       => null,
-        'headers'    => array(),
     );
 
     /**
@@ -46,11 +45,9 @@ abstract class AbstractHTTPClient implements Client
      * @param string $ip
      * @param bool $ssl
      * @param string $path
-     * @param int $timeout
-     * @param array $headers
      * @return \Doctrine\CouchDB\HTTP\AbstractHTTPClient
      */
-    public function __construct($host = 'localhost', $port = 5984, $username = null, $password = null, $ip = null , $ssl = false, $path = null, $timeout = 10, array $headers = array())
+    public function __construct($host = 'localhost', $port = 5984, $username = null, $password = null, $ip = null , $ssl = false, $path = null, $timeout = 10)
     {
         $this->options['host']     = (string) $host;
         $this->options['port']     = (int) $port;
@@ -59,7 +56,6 @@ public function __construct($host = 'localhost', $port = 5984, $username = null,
         $this->options['password'] = $password;
         $this->options['path']     = $path;
         $this->options['timeout']  = (float) $timeout;
-        $this->options['headers']  = $headers;
 
         if ($ip === null) {
             $this->options['ip'] = gethostbyname($this->options['host']);
@@ -90,7 +86,6 @@ public function setOption( $option, $value )
             break;
 
         case 'http-log':
-        case 'headers':
         case 'password':
         case 'username':
             $this->options[$option] = $value;

lib/Doctrine/CouchDB/HTTP/MultipartParserAndSender.php

@@ -50,8 +50,7 @@ public function __construct(
             $sourceOptions['ip'],
             $sourceOptions['ssl'],
             $sourceOptions['path'],
-            $sourceOptions['timeout'],
-            $sourceOptions['headers']
+            $sourceOptions['timeout']
         );
 
         $targetOptions = $target->getOptions();
@@ -63,8 +62,7 @@ public function __construct(
             $targetOptions['ip'],
             $targetOptions['ssl'],
             $targetOptions['path'],
-            $targetOptions['timeout'],
-            $sourceOptions['headers']
+            $targetOptions['timeout']
         );
     }
 

lib/Doctrine/CouchDB/HTTP/SocketClient.php

@@ -159,9 +159,6 @@ protected function buildRequest(
         // available in the locale net.
         $request .= "Connection: " . ($this->options['keep-alive'] ? 'Keep-Alive' : 'Close') . "\r\n";
 
-        if ($this->options['headers']) {
-            $headers = array_merge($this->options['headers'], $headers);
-        }
         if (!isset($headers['Content-Type'])) {
             $headers['Content-Type'] = 'application/json';
         }

lib/Doctrine/CouchDB/HTTP/StreamClient.php

@@ -81,9 +81,6 @@ protected function checkConnection($method, $path, $data, $headers)
         if ($this->options['username']) {
             $basicAuth .= "{$this->options['username']}:{$this->options['password']}@";
         }
-        if ($this->options['headers']) {
-            $headers = array_merge($this->options['headers'], $headers);
-        }
         if (!isset($headers['Content-Type'])) {
             $headers['Content-Type'] = 'application/json';
         }

tests/Doctrine/Tests/CouchDB/CouchDBClientTest.php

@@ -39,7 +39,6 @@ public function testCreateClientFromUrl()
                 'timeout' => 10,
                 'keep-alive' => true,
                 'path' => null,
-                'headers' => array(),
             ),
             $client->getHttpClient()->getOptions()
         );
@@ -61,24 +60,11 @@ public function testCreateClientFromUrlWithPath()
                 'timeout' => 10,
                 'keep-alive' => true,
                 'path' => 'baz/qux',
-                'headers' => array(),
             ),
             $client->getHttpClient()->getOptions()
         );
     }
 
-    public function testCreateClientWithDefaultHeaders()
-    {
-        $client = CouchDBClient::create(array('dbname' => 'test', 'headers' => array('X-Test' => 'test')));
-        $http_client = $client->getHttpClient();
-        $connection_options = $http_client->getOptions();
-        $this->assertSame(array('X-Test' => 'test'), $connection_options['headers']);
-
-        $http_client->setOption('headers', array('X-Test-New' => 'new'));
-        $connection_options = $http_client->getOptions();
-        $this->assertSame(array('X-Test-New' => 'new'), $connection_options['headers']);
-    }
-
     public function testCreateClientWithLogging()
     {
         $client = CouchDBClient::create(array('dbname' => 'test', 'logging' => true));

tests/Doctrine/Tests/CouchDB/CouchDBFunctionalTestCase.php

@@ -9,12 +9,7 @@ abstract class CouchDBFunctionalTestCase extends \PHPUnit_Framework_TestCase
 {
     private $httpClient = null;
 
-    protected function tearDown() {
-        parent::tearDown();
-        $this->createCouchDBClient()->deleteDatabase($this->getTestDatabase());
-    }
-
-  /**
+    /**
      * @return \Doctrine\CouchDB\HTTP\Client
      */
     public function getHttpClient()

tests/Doctrine/Tests/CouchDB/Functional/CouchDBClientTest.php

@@ -14,7 +14,6 @@ class CouchDBClientTest extends \Doctrine\Tests\CouchDB\CouchDBFunctionalTestCas
     public function setUp()
     {
         $this->couchClient = $this->createCouchDBClient();
-        $this->couchClient->createDatabase($this->getTestDatabase());
     }
 
     public function testGetUuids()
@@ -74,6 +73,7 @@ public function testDropMultipleTimesSkips()
      */
     public function testCreateDuplicateDatabaseThrowsException()
     {
+        $this->couchClient->createDatabase($this->getTestDatabase());
         $this->setExpectedException('Doctrine\CouchDB\HTTP\HTTPException', 'HTTP Error with status 412 occurred while requesting /'.$this->getTestDatabase().'. Error: file_exists The database could not be created, the file already exists.');
         $this->couchClient->createDatabase($this->getTestDatabase());
     }

tests/Doctrine/Tests/CouchDB/Functional/HTTP/MultipartParserAndSenderTest.php

@@ -52,12 +52,6 @@ public function setUp()
 
     }
 
-    public function tearDown()
-    {
-        parent::tearDown();
-        $this->createCouchDBClient()->deleteDatabase($this->getTestDatabase() . '_multipart_copy');
-    }
-
     public function testRequestThrowsHTTPExceptionOnEmptyStatus()
     {
         $this->setExpectedException(