Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disallow multiple structures per file #206

Open
wants to merge 4 commits into
base: 8.2.x
Choose a base branch
from

Conversation

gmponos
Copy link
Contributor

@gmponos gmponos commented Jun 20, 2020

No description provided.

@gmponos gmponos requested a review from a team as a code owner June 20, 2020 19:53
@gmponos gmponos force-pushed the disallow-multiple-structures branch from b35d963 to 7385a35 Compare June 21, 2020 20:18
Comment on lines +45 to +46
<!-- Only one structure (class/interface/trait) should be allowed per file -->
<rule ref="Generic.Files.OneObjectStructurePerFile" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't that part of some other rule already? Can you add some tests to check it, please?

@greg0ire greg0ire changed the base branch from master to 8.2.x October 25, 2020 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants