implement new sniff to force spaces after =

[Ocramius]

I haven't yet found the rule that will help with that (since MultipleStatementAlignmentSniff doesn't work here)

This PR/issue comes from this #103 (comment)

This is a copy of #117 as per #117 (comment)

[Ocramius]

Travis-CI really doesn't like this patch at all: I'll push it up as a branch of this repo.

[SenseException]

"Some checks haven’t completed yet" :-/

[SenseException]

If this is going to be the first custom code for the coding-standard, should it introduce the test environment like introduced in #63?

[vv12131415]

If this is going to be the first custom code for the coding-standard, should it introduce the test environment like introduced in #63?

I can add if you want

[Ocramius]

Yes, we'd most likely need proper coverage for new code, highlighting how much we're covering (branch-related). The existing tests are for regression/integration, and don't give us this confidence.

[malarzm]

I don't know much about writing own sniffs but given numer of tokens being registered I'd expect more tests than one assignment.

[vv12131415]

@malarzm yes, you are absolutely right! Thanks for mentioning this

[vv12131415]

@Ocramius ok, I've done all the things, but one thing that doesn't work as expected is #123 (comment)

[Ocramius]

@doctrine/coding-standard-approvers can I get your approvals/rejections in, please? I think further chore work should be deferred, unless it is something huge that wasn't spotted.

[malarzm]

Apart from missing newlines in some files it's 👍 from me

[jwage]

Awesome! 👍

[vv12131415]

Apart from missing newlines in some files it's from me

🤦‍♂️ yes, I see, I can fix it, but it will dismiss all of the reviews (don't want bother everyone yet another time)

[deeky666]

Apart from missing newlines in some files it's from me

man_facepalming yes, I see, I can fix it, but it will dismiss all of the reviews (don't want bother everyone yet another time)

that's the way it is, no worries :)

[vv12131415]

Can you retrigger Travis CI?

[carusogabriel]

🎉🎉🎉

[carusogabriel]

🎉🎉🎉

[carusogabriel]

Does this sniff works with:

$this->foo[$bar] =& $baz['quox'];

?

[malarzm]

=& looks like an operator to me, personally I prefer writing $this->foo[$bar] = &$baz['quox'];

[carusogabriel]

My bad, I was confusing this with +=, *=, .= 🤦‍♂️

[vv12131415]

@carusogabriel since there is #126 should I close this one? Or I need to make some changes here?

[carusogabriel]

@vladyslavstartsev Let's hold on this one until we get slevomat/cs v6 released, as well PHPCS v3.5 :)

[vv12131415]

@carusogabriel sure! 👍

[simPod]

We have created similar sniff a while ago

See
https://github.com/cdn77/coding-standard/blob/master/tests/Sniffs/Operators/data/OperatorSpacingSniffErrors.php
https://github.com/cdn77/coding-standard/blob/master/tests/Sniffs/Operators/data/OperatorSpacingSniffErrors.fixed.php

I wonder whether it would be possible to maybe reuse it here in some way?

[carusogabriel]

@simPod Looks like an idea. I hoped that PHPCS v3.5 would bring a fix to #126, but it looks like that didn't happen.

Unfortunately, we can't require cdn77/coding-standard here as that depends on doctrine/coding-standard, and it will always conflict with the master version.

Fell free to open a PR copying and pasting the sniff you created here if you allow us to use it, while we don't have the sniff of #126 ready to use 👍

[grongor]

Hi, I created the PR @carusogabriel requested, based on @simPod suggestion. Check it out here #134 :)