Allow locale to be retrieved from parent document #1338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 18, 2015 11:28
This allows the TranslatableListener to fetch the locale from a parent object in case the translated object is a MongoDB embedded document.
|
Just a head up that I've merged doctrine/mongodb-odm#1152 and have plan to merge doctrine/mongodb-odm#782 soon (by soon I mean probably tomorrow) |
l3pp4rd
added a commit
that referenced
this pull request
Jun 23, 2015
Allow locale to be retrieved from parent document
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1304.
Note: This requires doctrine/mongodb-odm#1152 to be merged first.
This applies when using ODM because doctrine/mongodb-odm#782 WILL break translations in embedded documents. With this change it is possible to have the
@Localeannotation in a root document and have that apply to ALL embedded documents within.