Skip to content

Added npm run dev command #1278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

kirbyfern
Copy link
Contributor

Summary
Added npm run dev command

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

@vercel
Copy link

vercel bot commented Jul 8, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/2crwozgq6
✅ Preview: https://docsify-preview-git-fork-kirbygit-contributing-guide.docsify-core.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 8, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e002369:

Sandbox Source
docsify-template Configuration

@kirbyfern
Copy link
Contributor Author

I think we should merge the PR from @trusktr so I can make the changes on the README

@anikethsaha
Copy link
Member

@kirbygit which PR is it ?

@ianjennings
Copy link

Depends on this PR #1203

@sy-records sy-records requested a review from trusktr July 23, 2020 01:23
@anikethsaha
Copy link
Member

Thanks , I guess that is still in WIP

cc @trusktr

@jhildenbiddle
Copy link
Member

This change doesn't make sense. Running npm run dev will start a server which will prevent users from entering the other commands as instructed. This is why the dev task is discussed separately.

I agree out our CONTRIBUTING.md doc needs some TLC, but this doesn't add value. Closing for now to reduce PR noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants