Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event binding of body.ready on mobile devices causes abnormal switching of the sidebar #1697

Open
1 task
askfiy opened this issue Dec 28, 2021 · 0 comments
Open
1 task

Comments

@askfiy
Copy link

askfiy commented Dec 28, 2021

Bug Report

On mobile devices, docsify will add a click event to the body element.
When the event is not removed, clicking any area in the left sidebar will trigger its switching function.
After removing the event, the function is normal.

Its position is between 1932 -> 1938:

   function btn(el) {
     var toggle = function (_) {return body.classList.toggle('close'); };

     el = getNode(el);
     if (el === null || el === undefined) {
       return;
     }

     on(el,'click', function (e) {
       e.stopPropagation();
       toggle();
     });
     // this position
     isMobile &&
       on(
         body,
         'click',
         function (_) {return body.classList.contains('close') && toggle();}
       );
   }

Just like in the picture, this is when I did not remove the event:

bug1

When I removed the event, everything returned to normal:

bug2

I don't understand the meaning of this event, because after I disable it, I feel that everything is normal.

Steps to reproduce

On mobile devices, click button.sidebar-toggle. Click again on any area in the sidebar.

What is current behaviour

It will automatically close the sidebar.

What is the expected behaviour

Only when the button.sidebar-toggle button is clicked, can the sidebar toggle function be triggered.

Other relevant information

  • Bug does still occur when all/other plugins are disabled?

  • Your OS: ubuntu 20.04.3 LTS

  • Node.js version: 10.24.1

  • npm/yarn version: 6.4.12

  • Browser version: any browser

  • Docsify version: 4.4.3

  • Docsify plugins:

gitalk
search
emoji
docsify-copy-code
countable
pangu
sidebar
progress
gifcontrol
pagination

Please create a reproducible sandbox

Edit 307qqv236

Mention the docsify version in which this bug was not present (if any)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants