Merge pull request #842 from Koooooo-7/develop

fix #835 :Link target of repo's GitHub Corner add new independent config `cornerExternalLinkTarget`.
docsifyjs · Dec 2, 2019 · 98525c4 · 98525c4
2 parents 8d5787e + e61410a
commit 98525c4
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 4 deletions.
diff --git a/docs/configuration.md b/docs/configuration.md
@@ -397,14 +397,27 @@ window.$docsify = {
 - type: `String`
 - default: `_blank`
 
-Target to open external links. Default `'_blank'` (new window/tab)
+Target to open external links inside the markdown. Default `'_blank'` (new window/tab)
 
 ```js
 window.$docsify = {
   externalLinkTarget: '_self' // default: '_blank'
 };
 ```
 
+## cornerExternalLinkTarget
+
+- type:`String`
+- default:`_blank`
+
+Target to open external link at the top right corner. Default `'_blank'` (new window/tab)
+
+```js
+window.$docsify = {
+  cornerExternalLinkTarget: '_self' // default: '_blank'
+};
+```
+
 ## routerMode
 
 - type: `String`

diff --git a/src/core/config.js b/src/core/config.js
@@ -23,7 +23,10 @@ export default function () {
       ext: '.md',
       mergeNavbar: false,
       formatUpdated: '',
+      // this config for the links inside markdown
       externalLinkTarget: '_blank',
+      // this config for the corner 
+      cornerExternalLinkTarget: '_blank',
       routerMode: 'hash',
       noCompileLinks: [],
       relativePath: false

diff --git a/src/core/render/index.js b/src/core/render/index.js
@@ -226,7 +226,7 @@ export function initRender(vm) {
 
   if (el) {
     if (config.repo) {
-      html += tpl.corner(config.repo)
+      html += tpl.corner(config.repo, config.cornerExternalLinkTarge)
     }
     if (config.coverpage) {
       html += tpl.cover()

diff --git a/src/core/render/tpl.js b/src/core/render/tpl.js
@@ -4,17 +4,19 @@ import {isMobile} from '../util/env'
  * @param  {Object} data
  * @return {String}
  */
-export function corner(data) {
+export function corner(data, cornerExternalLinkTarge) {
   if (!data) {
     return ''
   }
   if (!/\/\//.test(data)) {
     data = 'https://github.com/' + data
   }
   data = data.replace(/^git\+/, '')
+  // double check
+  cornerExternalLinkTarge = cornerExternalLinkTarge || '_blank'
 
   return (
-    `<a href="${data}" class="github-corner" aria-label="View source on Github">` +
+    `<a href="${data}" target="${cornerExternalLinkTarge}" class="github-corner" aria-label="View source on Github">` +
     '<svg viewBox="0 0 250 250" aria-hidden="true">' +
     '<path d="M0,0 L115,115 L130,115 L142,142 L250,250 L250,0 Z"></path>' +
     '<path d="M128.3,109.0 C113.8,99.7 119.0,89.6 119.0,89.6 C122.0,82.7 120.5,78.6 120.5,78.6 C119.2,72.0 123.4,76.3 123.4,76.3 C127.3,80.9 125.5,87.3 125.5,87.3 C122.9,97.6 130.6,101.9 134.4,103.2" fill="currentColor" style="transform-origin: 130px 106px;" class="octo-arm"></path>' +