test: add unit tests for speaker diarization assignment - #4040
Open
nassarofficial wants to merge 1 commit into
Open
test: add unit tests for speaker diarization assignment#4040nassarofficial wants to merge 1 commit into
nassarofficial wants to merge 1 commit into
Conversation
Cover assign_speakers overlap, empty, and missing-time edge cases, plus the diarize() missing-dependency fallback, without loading Resemblyzer. Signed-off-by: Ahmed Nassar AHN@zurich.ibm.com <AHN@zurich.ibm.com>
Contributor
|
✅ DCO Check Passed Thanks @nassarofficial, all your commits are properly signed off. 🎉 |
Contributor
Merge Protections🟢 Merge protection satisfied — ready to merge. Show 1 satisfied protection🟢 Enforce conventional commitMake sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add unit tests for docling.utils.speaker_diarization that lock down how ASR transcript cues get speaker labels. assign_speakers is pure time-overlap logic: empty diarization leaves items unchanged, empty transcripts stay empty, each cue is labeled with the diarization segment of maximum positive overlap, no-overlap and zero-length (missing start_time/end_time) cues leave speaker unset, and equal overlaps keep the first winner because the comparison is strict >. diarize() is only covered for the soft-fail path—when Resemblyzer (or related video extras) cannot be imported, it returns an empty DiarizationResult instead of raising—so the suite stays in the core CI lane without loading embedding models or decoding audio.