Add functionality to merge cells in Google OCR prediction #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cau-git
reviewed
May 21, 2025
There was a problem hiding this comment.
@samiuc since all of this is only required for Google OCR, please ensure that the code is kept in the google_prediction_provider.py module. We don't want this to spill into general docling-eval utils.
Also, one comment below.
docling_eval/prediction_providers/google_prediction_provider.py
Outdated
Show resolved
Hide resolved
PeterStaar-IBM
requested changes
May 24, 2025
| return y_overlap / y_union if y_union > 0 else 0 | ||
|
|
||
|
|
||
| def text_cell_to_word_dict(cell: TextCell): |
There was a problem hiding this comment.
please do not do this, keep using the TextCell!
| @@ -42,10 +41,364 @@ | |||
|
|
|||
| _log = logging.getLogger(__name__) | |||
|
|
|||
| SPECIAL_CHARS = list("*:;,.?()!@#$%^&[]{}/\\\"'~+-_<>=") | |||
There was a problem hiding this comment.
dont use toplevel constants, please make them part of a class!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The F1 scores regressed on Google for OCR as compared to the previous evaluations and upon investigating we found out that we had a functionality to merge cells before running the evaluations (only for Google OCR). Here's the overview of what the new code does: