Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: Could not find module @ember/polyfills imported from myapp/initializers/viewport-config #124

Closed
teakap opened this issue Feb 13, 2018 · 3 comments · Fixed by #125
Closed

Comments

@teakap
Copy link

teakap commented Feb 13, 2018

I get the error in the browser console as soon as the server runs.
I am using:
ember-in-viewport: ^2.1.1
ember-cli: ^2.12.3

I've cleaned node and bower modules a couple of times, but the issue remains. Any ideas?

@snewcomer
Copy link
Collaborator

@teakap Ah thank you for bringing our attention to this! The new ember imports @ember/... is only safe if it is in the addon folder. I think the instance-initializer essentially needs to be in the addon folder and re-exported in the app folder. Let me create an issue for it.

@snewcomer
Copy link
Collaborator

@teakap Would you mind trying out ember-in-viewport: "DockYard/ember-in-viewport" (master branch) in your package.json and lmk if the PR fixed it? We will release 2.2.1 if so. Thanks again!

@teakap
Copy link
Author

teakap commented Feb 15, 2018

@snewcomer I can confirm! No console errors, and the expected behavior is the actual behavior. Super quick response though! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants