preserve comments in list input values with commentNoInfix#607
Merged
tonistiigi merged 2 commits intodocker:masterfrom Mar 5, 2026
Merged
preserve comments in list input values with commentNoInfix#607tonistiigi merged 2 commits intodocker:masterfrom
tonistiigi merged 2 commits intodocker:masterfrom
Conversation
crazy-max
changed the title
Closed
3 tasks
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
allow-comments
branch
from
8b03650 to
4b529ac
Compare
tonistiigi
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #451
needs #604
Use
commentNoInfix: true(follow-up docker/actions-toolkit#1005) when parsing all list-style inputs (images, tags, flavor, labels, annotations). This keeps support for full-line#comments in multiline inputs while preserving#characters inside actual values (for examplemylabel=foo#bar), which currently gets truncated.