removed old content from liquid admonitions include file#3271
Merged
londoncalling merged 1 commit intodocker:masterfrom May 15, 2017
londoncalling:remove-old-icons-includes
Merged
removed old content from liquid admonitions include file#3271londoncalling merged 1 commit intodocker:masterfrom londoncalling:remove-old-icons-includes
londoncalling merged 1 commit intodocker:masterfrom
londoncalling:remove-old-icons-includes
Conversation
Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>
Contributor
Author
|
LGTM |
Contributor
|
Sorry for the late reply, but if we're removing the content on this file, can't we just delete the while file instead? |
Contributor
Author
|
@joaofnfernandes yes, I'll delete it, I was being ultra careful since I liked being reminded that there is this other option. I'll delete it in a few minutes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed
Related
#3253
Reviewers fyi
@johndmulhausen @joaofnfernandes @mstanleyjones
Signed-off-by: Victoria Bialas victoria.bialas@docker.com