Skip to content

removed old content from liquid admonitions include file #3271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2017
Merged

removed old content from liquid admonitions include file #3271

merged 1 commit into from
May 15, 2017

Conversation

londoncalling
Copy link
Contributor

@londoncalling londoncalling commented May 15, 2017

What's changed

  • Removed content from this older version of the admonitions include file because @johndmulhausen since created a more complete version of this solution in Creation of liquid-based notes/documentation of approach #3253. If we decide to use a Liquid solution, or even keep it as an alternative to FontAwesome icons, we should use John's version of the includes file, not mine. So, this will make it easier to merge that newer file, if needed. Otherwise, it's a placeholder which can be used or deleted later. Either way, makes no sense to keep the file as it was with content that didn't fully solve the problem.

Related

#3253

Reviewers fyi

@johndmulhausen @joaofnfernandes @mstanleyjones

Signed-off-by: Victoria Bialas victoria.bialas@docker.com

Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>
@londoncalling
Copy link
Contributor Author

LGTM

@londoncalling londoncalling merged commit 01f1704 into docker:master May 15, 2017
@joaofnfernandes
Copy link
Contributor

Sorry for the late reply, but if we're removing the content on this file, can't we just delete the while file instead?

@londoncalling
Copy link
Contributor Author

londoncalling commented May 15, 2017

@joaofnfernandes yes, I'll delete it, I was being ultra careful since I liked being reminded that there is this other option. I'll delete it in a few minutes.

@londoncalling londoncalling deleted the remove-old-icons-includes branch May 17, 2017 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants