Removed wrong information about container DNS #11012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the docs it says a container will inherit the host /etc/hosts file along with /etc/resolv.conf. While the latter part is correct, /etc/hosts will not actually be inherited, as reported moby/moby#39311. An additional line of text has been added to emphasize the fact that /etc/hosts are not inherited
|
Deploy preview for docsdocker ready! Built with commit 113876b |
thaJeztah
reviewed
Jun 18, 2020
Co-authored-by: Sebastiaan van Stijn <thaJeztah@users.noreply.github.com>
usha-mandya
approved these changes
Jun 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
In the docs it says a container will inherit the host /etc/hosts file along with /etc/resolv.conf. While the latter part is correct, /etc/hosts will not actually be inherited.
This PR will update the paragraph to tell reader only the file /etc/resolv.conf will be inherited. In addition to that, some texts have been added to emphasize the fact that /etc/hosts are not inherited
If there's anything wrong with the grammar or the sentence structure, do let me know and I will amend accordingly
Related issues
moby/moby#39311