Skip to content

Commit 3ad75e0

Browse files
committed
Fix non-stream logs for python3
1 parent 8a63e70 commit 3ad75e0

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

docker/client.py

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -624,8 +624,16 @@ def logs(self, container, stdout=True, stderr=True, stream=False,
624624
'follow': stream and 1 or 0}
625625
url = self._url("/containers/{0}/logs".format(container))
626626
res = self._get(url, params=params, stream=stream)
627-
return stream and self._multiplexed_socket_stream_helper(res) or \
628-
''.join([x for x in self._multiplexed_buffer_helper(res)])
627+
if stream:
628+
return self._multiplexed_socket_stream_helper(res)
629+
elif six.PY3:
630+
return bytes().join(
631+
[x for x in self._multiplexed_buffer_helper(res)]
632+
)
633+
else:
634+
return str().join(
635+
[x for x in self._multiplexed_buffer_helper(res)]
636+
)
629637
return self.attach(
630638
container,
631639
stdout=stdout,

0 commit comments

Comments
 (0)