fix collect image digests for service images built by bake #12784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
force-pushed
the
bake_service_image
branch
3 times, most recently
from
6e384a5 to
47443c2
Compare
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
ndeloof
force-pushed
the
bake_service_image
branch
from
47443c2 to
a9aea9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fix: collect build images from bake output metdata indexed by expected image tag, not service name
Note: bake returns
image.namebut we can't rely on this as this is set with fully qualified name (docker.io/library/foo:latest) and user could have configured a "familiar name" (fooorfoo:latest). So I preferred to use the list of expected built targets and check those were found in metadata.Related issue
fixes #12774
(not mandatory) A picture of a cute animal, if possible in relation to what you did