Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vendor: update net and sys #1926

Merged
merged 1 commit into from
Jun 6, 2019
Merged

vendor: update net and sys #1926

merged 1 commit into from
Jun 6, 2019

Conversation

tonistiigi
Copy link
Member

Allows building the client on riscv64

Signed-off-by: Tonis Tiigi tonistiigi@gmail.com

@tonistiigi
vendor: update net and sys
668a9ff 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tiborvass
tiborvass approved these changes Jun 5, 2019
View reviewed changes
Copy link
Collaborator

@tiborvass tiborvass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For those being worried about the additional 30k lines, they are all mostly syscall definitions behind build tags, so the regular amd64 binary should not suffer in size.

thaJeztah
thaJeztah approved these changes Jun 6, 2019
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 2ec7306 into docker:master Jun 6, 2019
@GordonTheTurtle GordonTheTurtle added this to the 19.09.0 milestone Jun 6, 2019
@thaJeztah thaJeztah mentioned this pull request Jan 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thaJeztah thaJeztah thaJeztah approved these changes

@tiborvass tiborvass tiborvass approved these changes

Assignees
No one assigned
Labels
status/2-code-review
Projects
None yet
Milestone
20.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@tonistiigi @tiborvass @thaJeztah @GordonTheTurtle