Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The socket package should hanndle reconnects and possibly mutliple connections #4899

Open
Benehiko opened this issue Feb 27, 2024 · 0 comments

Comments

@Benehiko
Copy link
Member

Description

The CLI socket package allows for plugins to connect to the CLI. The CLI uses this connection to signal to the plugin when to exit, based on OS termination signals. The current implementation does not allows for the plugin to reconnect to the CLI and the CLI has no way of handling multiple connections.

In the future we might want to allow for such situations. For example, the plugin might drop a connection and redial or a plugin might spawn another or the CLI might spawn multiple.

For context, please see this PR #4878

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant