Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'sirupsen/logrus' import statements #465

Closed
8 tasks
vdemeester opened this issue Aug 23, 2017 · 2 comments
Closed
8 tasks

Fix 'sirupsen/logrus' import statements #465

vdemeester opened this issue Aug 23, 2017 · 2 comments
Assignees

Comments

@vdemeester
Copy link
Collaborator

vdemeester commented Aug 23, 2017

Related to moby/moby#33641, from initial issue on moby/moby

It appears that everything in this project is using the package name Sirupsen/logrus instead of sirupsen/logrus as is suggested by the readme:

Seeing weird case-sensitive problems? Unfortunately, the author failed to realize the consequences of renaming to lower-case. Due to the Go package environment, this caused issues. Regretfully, there's no turning back now. Everything using logrus will need to use the lower-case: github.com/sirupsen/logrus. Any package that isn't, should be changed.

moby/moby is fixing it (i.e. using sirupsen lowercase) and as it is a dependency of cli (as docker/docker for now), we are also going to handle that in this repository. This issue is there to track that move.

@vdemeester vdemeester self-assigned this Aug 23, 2017
@shouze
Copy link
Contributor

shouze commented Aug 26, 2017

@vdemeester ok I've just encountered that issue... as I wanted to upgrade github.com/docker/docker hash to the one of the merge of moby/moby#34590 & continue work on moby/moby#32816 fix so this is blocking me ATM.

I've check and looks like that only notary is waiting for notaryproject/notary#1211 to get merged then it will be ok no? All the other dependencies have been fixed, so close to a cli patch 😉.

Anyway I'm ok to contribute to unlock that when notaryproject/notary#1211 will get merged.

@shouze
Copy link
Contributor

shouze commented Sep 8, 2017

@vdemeester ok since notaryproject/notary#1225 has been merged, I guess this issue can be closed no?

@dnephin dnephin closed this as completed Sep 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants