Skip to content

Breaking change included in subversion release #778

@zymotik

Description

@zymotik

Many thanks for your action, we appreciate your hard work. However:

Behaviour

v3.3 included a warning message This may introduce issues with registry and runtime support (e.g. GCR and Lambda). May I suggest that in future, known breaking changes are left for major version changes. It would have saved some headache troubleshooting why we were getting Image 'eu.gcr.io/{project-id}/image-name' not found errors in our Cloud Run deployments.

Expected behaviour

Action conforms to Semantic Versioning

Actual behaviour

Minor version release impacted publish to GCR

Configuration

      - name: Build and Push to the Google Container Registry
        uses: docker/build-push-action@v3
        with:
          context: ./
          file: ./Dockerfile
          push: ${{ github.actor == 'dependabot[bot]' && 'false' || 'true' }}
          tags: ${{ env.image_tags }}

Fix

      - name: Build and Push to the Google Container Registry
        uses: docker/build-push-action@v3
        with:
          ...
          provenance: false

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions