git context support #181
Merged
git context support #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazy-max
force-pushed
the
git-context
branch
3 times, most recently
from
a172b52 to
cebbe70
Compare
crazy-max
force-pushed
the
git-context
branch
from
cebbe70 to
5bb03f9
Compare
tonistiigi
reviewed
Dec 19, 2023
tonistiigi
reviewed
Dec 19, 2023
crazy-max
force-pushed
the
git-context
branch
4 times, most recently
from
ac98cef to
b8b648a
Compare
Member
Author
|
@tonistiigi As discussed this is now opt-in and will open a new PR to make it opt-out like the build-push-action does and create a major release. |
crazy-max
force-pushed
the
git-context
branch
2 times, most recently
from
679a384 to
c6c63bf
Compare
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
tonistiigi
approved these changes
Mar 11, 2024
This was referenced Mar 12, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @tonistiigi, we should support building from the default git context to have a better traceability of the build. This doesn't automatically set (yet) the
GIT_AUTH_TOKENlike the build-push-action does: https://github.com/docker/build-push-action/#git-contextThis is currently not the default behavior like build-push-action, to let user test this feature in their workflow but will be on next major release of this action.