Download node binary and SHASUMs via HTTPS #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM (nodejs/docker-node@95a8684...3e0d2b6) Build test of #847; 5421c7f ( $ url="https://raw.githubusercontent.com/docker-library/official-images/5421c7fce67667959cb09db2c06ea86697830718/library/node"
$ bashbrew build "$url"
Fetching node (git://github.com/joyent/docker-node) ...
Processing node:0.10.39 ...
Processing node:0.10 ...
Processing node:0.10.39-onbuild ...
Processing node:0.10-onbuild ...
Processing node:0.10.39-slim ...
Processing node:0.10-slim ...
Processing node:0.10.39-wheezy ...
Processing node:0.10-wheezy ...
Processing node:0.12.5 ...
Processing node:0.12 ...
Processing node:0 ...
Processing node:latest ...
Processing node:0.12.5-onbuild ...
Processing node:0.12-onbuild ...
Processing node:0-onbuild ...
Processing node:onbuild ...
Processing node:0.12.5-slim ...
Processing node:0.12-slim ...
Processing node:0-slim ...
Processing node:slim ...
Processing node:0.12.5-wheezy ...
Processing node:0.12-wheezy ...
Processing node:0-wheezy ...
Processing node:wheezy ...
Processing node:0.8.28 ...
Processing node:0.8 ...
Processing node:0.8.28-onbuild ...
Processing node:0.8-onbuild ...
Processing node:0.8.28-slim ...
Processing node:0.8-slim ...
Processing node:0.8.28-wheezy ...
Processing node:0.8-wheezy ...
$ bashbrew list --uniq "$url" | xargs test/run.sh
testing node:0.10.39
'utc' [1/3]...passed
'cve-2014--shellshock' [2/3]...passed
'no-hard-coded-passwords' [3/3]...passed
testing node:0.10.39-onbuild
'utc' [1/3]...passed
'cve-2014--shellshock' [2/3]...passed
'no-hard-coded-passwords' [3/3]...passed
testing node:0.10.39-slim
'utc' [1/3]...passed
'cve-2014--shellshock' [2/3]...passed
'no-hard-coded-passwords' [3/3]...passed
testing node:0.10.39-wheezy
'utc' [1/3]...passed
'cve-2014--shellshock' [2/3]...passed
'no-hard-coded-passwords' [3/3]...passed
testing node:0.12.5
'utc' [1/3]...passed
'cve-2014--shellshock' [2/3]...passed
'no-hard-coded-passwords' [3/3]...passed
testing node:0.12.5-onbuild
'utc' [1/3]...passed
'cve-2014--shellshock' [2/3]...passed
'no-hard-coded-passwords' [3/3]...passed
testing node:0.12.5-slim
'utc' [1/3]...passed
'cve-2014--shellshock' [2/3]...passed
'no-hard-coded-passwords' [3/3]...passed
testing node:0.12.5-wheezy
'utc' [1/3]...passed
'cve-2014--shellshock' [2/3]...passed
'no-hard-coded-passwords' [3/3]...passed
testing node:0.8.28
'utc' [1/3]...passed
'cve-2014--shellshock' [2/3]...passed
'no-hard-coded-passwords' [3/3]...passed
testing node:0.8.28-onbuild
'utc' [1/3]...passed
'cve-2014--shellshock' [2/3]...passed
'no-hard-coded-passwords' [3/3]...passed
testing node:0.8.28-slim
'utc' [1/3]...passed
'cve-2014--shellshock' [2/3]...passed
'no-hard-coded-passwords' [3/3]...passed
testing node:0.8.28-wheezy
'utc' [1/3]...passed
'cve-2014--shellshock' [2/3]...passed
'no-hard-coded-passwords' [3/3]...passed |
|
LGTM |
yosifkit
added a commit
that referenced
this pull request
Jun 25, 2015
Download node binary and SHASUMs via HTTPS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the Dockerfiles so that the Node.js binaries and SHASUM files are downloaded via https rather than http. For the slim variant, this also meant having to install (then uninstall) the ca-certificates package.
All the test builds look good!