Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for Node.js v8.9.0 & v9.0.0 #3655

Merged
merged 1 commit into from
Nov 1, 2017
Merged

Update for Node.js v8.9.0 & v9.0.0 #3655

merged 1 commit into from
Nov 1, 2017

Conversation

PeterDaveHello
Copy link
Contributor

@PeterDaveHello PeterDaveHello commented Nov 1, 2017 •
edited
Loading

@PeterDaveHello PeterDaveHello mentioned this pull request Nov 1, 2017
Merged
@chrisdoc chrisdoc mentioned this pull request Nov 1, 2017
Closed
@PeterDaveHello PeterDaveHello mentioned this pull request Nov 1, 2017
Closed
@PeterDaveHello PeterDaveHello mentioned this pull request Nov 1, 2017
Merged
@PeterDaveHello PeterDaveHello changed the title Update for Node.js v8.9.0 Update for Node.js v8.9.0 & v9.0.0 Nov 1, 2017
@timbru31 timbru31 mentioned this pull request Nov 1, 2017
Closed
@tianon
Copy link
Member

tianon commented Nov 1, 2017

Diff: 
diff --git a/_bashbrew-arches b/_bashbrew-arches
index ca0a2ba..a9496a7 100644
--- a/_bashbrew-arches
+++ b/_bashbrew-arches
@@ -39,6 +39,28 @@ node:boron-stretch @ arm64v8
 node:boron-stretch @ ppc64le
 node:boron-stretch @ s390x
 node:boron-wheezy @ amd64
+node:carbon @ amd64
+node:carbon @ arm32v7
+node:carbon @ arm64v8
+node:carbon @ ppc64le
+node:carbon @ s390x
+node:carbon-alpine @ amd64
+node:carbon-onbuild @ amd64
+node:carbon-onbuild @ arm32v7
+node:carbon-onbuild @ arm64v8
+node:carbon-onbuild @ ppc64le
+node:carbon-onbuild @ s390x
+node:carbon-slim @ amd64
+node:carbon-slim @ arm32v7
+node:carbon-slim @ arm64v8
+node:carbon-slim @ ppc64le
+node:carbon-slim @ s390x
+node:carbon-stretch @ amd64
+node:carbon-stretch @ arm32v7
+node:carbon-stretch @ arm64v8
+node:carbon-stretch @ ppc64le
+node:carbon-stretch @ s390x
+node:carbon-wheezy @ amd64
 node:latest @ amd64
 node:latest @ arm32v7
 node:latest @ arm64v8
diff --git a/_bashbrew-list b/_bashbrew-list
index a497264..98d5dba 100644
--- a/_bashbrew-list
+++ b/_bashbrew-list
@@ -40,18 +40,36 @@ node:8-onbuild
 node:8-slim
 node:8-stretch
 node:8-wheezy
-node:8.8
-node:8.8-alpine
-node:8.8-onbuild
-node:8.8-slim
-node:8.8-stretch
-node:8.8-wheezy
-node:8.8.1
-node:8.8.1-alpine
-node:8.8.1-onbuild
-node:8.8.1-slim
-node:8.8.1-stretch
-node:8.8.1-wheezy
+node:8.9
+node:8.9-alpine
+node:8.9-onbuild
+node:8.9-slim
+node:8.9-stretch
+node:8.9-wheezy
+node:8.9.0
+node:8.9.0-alpine
+node:8.9.0-onbuild
+node:8.9.0-slim
+node:8.9.0-stretch
+node:8.9.0-wheezy
+node:9
+node:9-alpine
+node:9-onbuild
+node:9-slim
+node:9-stretch
+node:9-wheezy
+node:9.0
+node:9.0-alpine
+node:9.0-onbuild
+node:9.0-slim
+node:9.0-stretch
+node:9.0-wheezy
+node:9.0.0
+node:9.0.0-alpine
+node:9.0.0-onbuild
+node:9.0.0-slim
+node:9.0.0-stretch
+node:9.0.0-wheezy
 node:alpine
 node:argon
 node:argon-alpine
@@ -65,6 +83,12 @@ node:boron-onbuild
 node:boron-slim
 node:boron-stretch
 node:boron-wheezy
+node:carbon
+node:carbon-alpine
+node:carbon-onbuild
+node:carbon-slim
+node:carbon-stretch
+node:carbon-wheezy
 node:latest
 node:onbuild
 node:slim
diff --git a/node_alpine/Dockerfile b/node_alpine/Dockerfile
index 56d8e42..b9e59ac 100644
--- a/node_alpine/Dockerfile
+++ b/node_alpine/Dockerfile
@@ -1,6 +1,6 @@
 FROM alpine:3.6
 
-ENV NODE_VERSION 8.8.1
+ENV NODE_VERSION 9.0.0
 
 RUN addgroup -g 1000 node \
     && adduser -u 1000 -G node -s /bin/sh -D node \
@@ -25,6 +25,7 @@ RUN addgroup -g 1000 node \
     C4F0DFFF4E8C1A8236409D08E73BC641CC11F4C8 \
     B9AE9905FFD7803F25714661B63B535A4C206CA9 \
     56730D5401028683275BD23C23EFEFE93C4CFFFE \
+    77984A986EBC2AA786BC0F66B01FBB92821C587A \
   ; do \
     gpg --keyserver pgp.mit.edu --recv-keys "$key" || \
     gpg --keyserver keyserver.pgp.com --recv-keys "$key" || \
diff --git a/node_argon-alpine/Dockerfile b/node_argon-alpine/Dockerfile
index 3622b48..3e54f54 100644
--- a/node_argon-alpine/Dockerfile
+++ b/node_argon-alpine/Dockerfile
@@ -25,6 +25,7 @@ RUN addgroup -g 1000 node \
     C4F0DFFF4E8C1A8236409D08E73BC641CC11F4C8 \
     B9AE9905FFD7803F25714661B63B535A4C206CA9 \
     56730D5401028683275BD23C23EFEFE93C4CFFFE \
+    77984A986EBC2AA786BC0F66B01FBB92821C587A \
   ; do \
     gpg --keyserver pgp.mit.edu --recv-keys "$key" || \
     gpg --keyserver keyserver.pgp.com --recv-keys "$key" || \
diff --git a/node_argon-slim/Dockerfile b/node_argon-slim/Dockerfile
index 27d9b9e..9d45ffa 100644
--- a/node_argon-slim/Dockerfile
+++ b/node_argon-slim/Dockerfile
@@ -13,6 +13,7 @@ RUN set -ex \
     C4F0DFFF4E8C1A8236409D08E73BC641CC11F4C8 \
     B9AE9905FFD7803F25714661B63B535A4C206CA9 \
     56730D5401028683275BD23C23EFEFE93C4CFFFE \
+    77984A986EBC2AA786BC0F66B01FBB92821C587A \
   ; do \
     gpg --keyserver pgp.mit.edu --recv-keys "$key" || \
     gpg --keyserver keyserver.pgp.com --recv-keys "$key" || \
diff --git a/node_argon-stretch/Dockerfile b/node_argon-stretch/Dockerfile
index 070fa1f..0952735 100644
--- a/node_argon-stretch/Dockerfile
+++ b/node_argon-stretch/Dockerfile
@@ -13,6 +13,7 @@ RUN set -ex \
     C4F0DFFF4E8C1A8236409D08E73BC641CC11F4C8 \
     B9AE9905FFD7803F25714661B63B535A4C206CA9 \
     56730D5401028683275BD23C23EFEFE93C4CFFFE \
+    77984A986EBC2AA786BC0F66B01FBB92821C587A \
   ; do \
     gpg --keyserver pgp.mit.edu --recv-keys "$key" || \
     gpg --keyserver keyserver.pgp.com --recv-keys "$key" || \
diff --git a/node_argon-wheezy/Dockerfile b/node_argon-wheezy/Dockerfile
index 8907fe8..907b89d 100644
--- a/node_argon-wheezy/Dockerfile
+++ b/node_argon-wheezy/Dockerfile
@@ -13,6 +13,7 @@ RUN set -ex \
     C4F0DFFF4E8C1A8236409D08E73BC641CC11F4C8 \
     B9AE9905FFD7803F25714661B63B535A4C206CA9 \
     56730D5401028683275BD23C23EFEFE93C4CFFFE \
+    77984A986EBC2AA786BC0F66B01FBB92821C587A \
   ; do \
     gpg --keyserver pgp.mit.edu --recv-keys "$key" || \
     gpg --keyserver keyserver.pgp.com --recv-keys "$key" || \
diff --git a/node_argon/Dockerfile b/node_argon/Dockerfile
index 69ae9b3..c5327ff 100644
--- a/node_argon/Dockerfile
+++ b/node_argon/Dockerfile
@@ -13,6 +13,7 @@ RUN set -ex \
     C4F0DFFF4E8C1A8236409D08E73BC641CC11F4C8 \
     B9AE9905FFD7803F25714661B63B535A4C206CA9 \
     56730D5401028683275BD23C23EFEFE93C4CFFFE \
+    77984A986EBC2AA786BC0F66B01FBB92821C587A \
   ; do \
     gpg --keyserver pgp.mit.edu --recv-keys "$key" || \
     gpg --keyserver keyserver.pgp.com --recv-keys "$key" || \
diff --git a/node_boron-alpine/Dockerfile b/node_boron-alpine/Dockerfile
index ad5d6f1..ab3b461 100644
--- a/node_boron-alpine/Dockerfile
+++ b/node_boron-alpine/Dockerfile
@@ -25,6 +25,7 @@ RUN addgroup -g 1000 node \
     C4F0DFFF4E8C1A8236409D08E73BC641CC11F4C8 \
     B9AE9905FFD7803F25714661B63B535A4C206CA9 \
     56730D5401028683275BD23C23EFEFE93C4CFFFE \
+    77984A986EBC2AA786BC0F66B01FBB92821C587A \
   ; do \
     gpg --keyserver pgp.mit.edu --recv-keys "$key" || \
     gpg --keyserver keyserver.pgp.com --recv-keys "$key" || \
diff --git a/node_boron-slim/Dockerfile b/node_boron-slim/Dockerfile
index 0c771e5..cf34dee 100644
--- a/node_boron-slim/Dockerfile
+++ b/node_boron-slim/Dockerfile
@@ -13,6 +13,7 @@ RUN set -ex \
     C4F0DFFF4E8C1A8236409D08E73BC641CC11F4C8 \
     B9AE9905FFD7803F25714661B63B535A4C206CA9 \
     56730D5401028683275BD23C23EFEFE93C4CFFFE \
+    77984A986EBC2AA786BC0F66B01FBB92821C587A \
   ; do \
     gpg --keyserver pgp.mit.edu --recv-keys "$key" || \
     gpg --keyserver keyserver.pgp.com --recv-keys "$key" || \
diff --git a/node_boron-stretch/Dockerfile b/node_boron-stretch/Dockerfile
index 2670bc0..4e11e09 100644
--- a/node_boron-stretch/Dockerfile
+++ b/node_boron-stretch/Dockerfile
@@ -13,6 +13,7 @@ RUN set -ex \
     C4F0DFFF4E8C1A8236409D08E73BC641CC11F4C8 \
     B9AE9905FFD7803F25714661B63B535A4C206CA9 \
     56730D5401028683275BD23C23EFEFE93C4CFFFE \
+    77984A986EBC2AA786BC0F66B01FBB92821C587A \
   ; do \
     gpg --keyserver pgp.mit.edu --recv-keys "$key" || \
     gpg --keyserver keyserver.pgp.com --recv-keys "$key" || \
diff --git a/node_boron-wheezy/Dockerfile b/node_boron-wheezy/Dockerfile
index bde7c3d..8073a08 100644
--- a/node_boron-wheezy/Dockerfile
+++ b/node_boron-wheezy/Dockerfile
@@ -13,6 +13,7 @@ RUN set -ex \
     C4F0DFFF4E8C1A8236409D08E73BC641CC11F4C8 \
     B9AE9905FFD7803F25714661B63B535A4C206CA9 \
     56730D5401028683275BD23C23EFEFE93C4CFFFE \
+    77984A986EBC2AA786BC0F66B01FBB92821C587A \
   ; do \
     gpg --keyserver pgp.mit.edu --recv-keys "$key" || \
     gpg --keyserver keyserver.pgp.com --recv-keys "$key" || \
diff --git a/node_boron/Dockerfile b/node_boron/Dockerfile
index 8e34897..602c0f4 100644
--- a/node_boron/Dockerfile
+++ b/node_boron/Dockerfile
@@ -13,6 +13,7 @@ RUN set -ex \
     C4F0DFFF4E8C1A8236409D08E73BC641CC11F4C8 \
     B9AE9905FFD7803F25714661B63B535A4C206CA9 \
     56730D5401028683275BD23C23EFEFE93C4CFFFE \
+    77984A986EBC2AA786BC0F66B01FBB92821C587A \
   ; do \
     gpg --keyserver pgp.mit.edu --recv-keys "$key" || \
     gpg --keyserver keyserver.pgp.com --recv-keys "$key" || \
diff --git a/node_alpine/Dockerfile b/node_carbon-alpine/Dockerfile
similarity index 97%
copy from node_alpine/Dockerfile
copy to node_carbon-alpine/Dockerfile
index 56d8e42..8e3de51 100644
--- a/node_alpine/Dockerfile
+++ b/node_carbon-alpine/Dockerfile
@@ -1,6 +1,6 @@
 FROM alpine:3.6
 
-ENV NODE_VERSION 8.8.1
+ENV NODE_VERSION 8.9.0
 
 RUN addgroup -g 1000 node \
     && adduser -u 1000 -G node -s /bin/sh -D node \
@@ -25,6 +25,7 @@ RUN addgroup -g 1000 node \
     C4F0DFFF4E8C1A8236409D08E73BC641CC11F4C8 \
     B9AE9905FFD7803F25714661B63B535A4C206CA9 \
     56730D5401028683275BD23C23EFEFE93C4CFFFE \
+    77984A986EBC2AA786BC0F66B01FBB92821C587A \
   ; do \
     gpg --keyserver pgp.mit.edu --recv-keys "$key" || \
     gpg --keyserver keyserver.pgp.com --recv-keys "$key" || \
diff --git a/node_argon-onbuild/Dockerfile b/node_carbon-onbuild/Dockerfile
similarity index 93%
copy from node_argon-onbuild/Dockerfile
copy to node_carbon-onbuild/Dockerfile
index 8eb0246..91ca7db 100644
--- a/node_argon-onbuild/Dockerfile
+++ b/node_carbon-onbuild/Dockerfile
@@ -1,4 +1,4 @@
-FROM node:4.8.5
+FROM node:8.9.0
 
 RUN mkdir -p /usr/src/app
 WORKDIR /usr/src/app
diff --git a/node_boron-slim/Dockerfile b/node_carbon-slim/Dockerfile
similarity index 97%
copy from node_boron-slim/Dockerfile
copy to node_carbon-slim/Dockerfile
index 0c771e5..41ac82b 100644
--- a/node_boron-slim/Dockerfile
+++ b/node_carbon-slim/Dockerfile
@@ -13,13 +13,14 @@ RUN set -ex \
     C4F0DFFF4E8C1A8236409D08E73BC641CC11F4C8 \
     B9AE9905FFD7803F25714661B63B535A4C206CA9 \
     56730D5401028683275BD23C23EFEFE93C4CFFFE \
+    77984A986EBC2AA786BC0F66B01FBB92821C587A \
   ; do \
     gpg --keyserver pgp.mit.edu --recv-keys "$key" || \
     gpg --keyserver keyserver.pgp.com --recv-keys "$key" || \
     gpg --keyserver ha.pool.sks-keyservers.net --recv-keys "$key" ; \
   done
 
-ENV NODE_VERSION 6.11.5
+ENV NODE_VERSION 8.9.0
 
 RUN buildDeps='xz-utils' \
     && ARCH= && dpkgArch="$(dpkg --print-architecture)" \
diff --git a/node_stretch/Dockerfile b/node_carbon-stretch/Dockerfile
similarity index 97%
copy from node_stretch/Dockerfile
copy to node_carbon-stretch/Dockerfile
index 683e1e0..c0b28e3 100644
--- a/node_stretch/Dockerfile
+++ b/node_carbon-stretch/Dockerfile
@@ -13,13 +13,14 @@ RUN set -ex \
     C4F0DFFF4E8C1A8236409D08E73BC641CC11F4C8 \
     B9AE9905FFD7803F25714661B63B535A4C206CA9 \
     56730D5401028683275BD23C23EFEFE93C4CFFFE \
+    77984A986EBC2AA786BC0F66B01FBB92821C587A \
   ; do \
     gpg --keyserver pgp.mit.edu --recv-keys "$key" || \
     gpg --keyserver keyserver.pgp.com --recv-keys "$key" || \
     gpg --keyserver ha.pool.sks-keyservers.net --recv-keys "$key" ; \
   done
 
-ENV NODE_VERSION 8.8.1
+ENV NODE_VERSION 8.9.0
 
 RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \
   && case "${dpkgArch##*-}" in \
diff --git a/node_argon-wheezy/Dockerfile b/node_carbon-wheezy/Dockerfile
similarity index 97%
copy from node_argon-wheezy/Dockerfile
copy to node_carbon-wheezy/Dockerfile
index 8907fe8..44dddf0 100644
--- a/node_argon-wheezy/Dockerfile
+++ b/node_carbon-wheezy/Dockerfile
@@ -13,13 +13,14 @@ RUN set -ex \
     C4F0DFFF4E8C1A8236409D08E73BC641CC11F4C8 \
     B9AE9905FFD7803F25714661B63B535A4C206CA9 \
     56730D5401028683275BD23C23EFEFE93C4CFFFE \
+    77984A986EBC2AA786BC0F66B01FBB92821C587A \
   ; do \
     gpg --keyserver pgp.mit.edu --recv-keys "$key" || \
     gpg --keyserver keyserver.pgp.com --recv-keys "$key" || \
     gpg --keyserver ha.pool.sks-keyservers.net --recv-keys "$key" ; \
   done
 
-ENV NODE_VERSION 4.8.5
+ENV NODE_VERSION 8.9.0
 
 RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \
   && case "${dpkgArch##*-}" in \
diff --git a/node_boron/Dockerfile b/node_carbon/Dockerfile
similarity index 97%
copy from node_boron/Dockerfile
copy to node_carbon/Dockerfile
index 8e34897..d65f593 100644
--- a/node_boron/Dockerfile
+++ b/node_carbon/Dockerfile
@@ -13,13 +13,14 @@ RUN set -ex \
     C4F0DFFF4E8C1A8236409D08E73BC641CC11F4C8 \
     B9AE9905FFD7803F25714661B63B535A4C206CA9 \
     56730D5401028683275BD23C23EFEFE93C4CFFFE \
+    77984A986EBC2AA786BC0F66B01FBB92821C587A \
   ; do \
     gpg --keyserver pgp.mit.edu --recv-keys "$key" || \
     gpg --keyserver keyserver.pgp.com --recv-keys "$key" || \
     gpg --keyserver ha.pool.sks-keyservers.net --recv-keys "$key" ; \
   done
 
-ENV NODE_VERSION 6.11.5
+ENV NODE_VERSION 8.9.0
 
 RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \
   && case "${dpkgArch##*-}" in \
diff --git a/node_latest/Dockerfile b/node_latest/Dockerfile
index 1339c40..baa3996 100644
--- a/node_latest/Dockerfile
+++ b/node_latest/Dockerfile
@@ -13,13 +13,14 @@ RUN set -ex \
     C4F0DFFF4E8C1A8236409D08E73BC641CC11F4C8 \
     B9AE9905FFD7803F25714661B63B535A4C206CA9 \
     56730D5401028683275BD23C23EFEFE93C4CFFFE \
+    77984A986EBC2AA786BC0F66B01FBB92821C587A \
   ; do \
     gpg --keyserver pgp.mit.edu --recv-keys "$key" || \
     gpg --keyserver keyserver.pgp.com --recv-keys "$key" || \
     gpg --keyserver ha.pool.sks-keyservers.net --recv-keys "$key" ; \
   done
 
-ENV NODE_VERSION 8.8.1
+ENV NODE_VERSION 9.0.0
 
 RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \
   && case "${dpkgArch##*-}" in \
diff --git a/node_onbuild/Dockerfile b/node_onbuild/Dockerfile
index a363cba..7749eb6 100644
--- a/node_onbuild/Dockerfile
+++ b/node_onbuild/Dockerfile
@@ -1,4 +1,4 @@
-FROM node:8.8.1
+FROM node:9.0.0
 
 RUN mkdir -p /usr/src/app
 WORKDIR /usr/src/app
diff --git a/node_slim/Dockerfile b/node_slim/Dockerfile
index 03b2ccf..949e13e 100644
--- a/node_slim/Dockerfile
+++ b/node_slim/Dockerfile
@@ -13,13 +13,14 @@ RUN set -ex \
     C4F0DFFF4E8C1A8236409D08E73BC641CC11F4C8 \
     B9AE9905FFD7803F25714661B63B535A4C206CA9 \
     56730D5401028683275BD23C23EFEFE93C4CFFFE \
+    77984A986EBC2AA786BC0F66B01FBB92821C587A \
   ; do \
     gpg --keyserver pgp.mit.edu --recv-keys "$key" || \
     gpg --keyserver keyserver.pgp.com --recv-keys "$key" || \
     gpg --keyserver ha.pool.sks-keyservers.net --recv-keys "$key" ; \
   done
 
-ENV NODE_VERSION 8.8.1
+ENV NODE_VERSION 9.0.0
 
 RUN buildDeps='xz-utils' \
     && ARCH= && dpkgArch="$(dpkg --print-architecture)" \
diff --git a/node_stretch/Dockerfile b/node_stretch/Dockerfile
index 683e1e0..91f21a6 100644
--- a/node_stretch/Dockerfile
+++ b/node_stretch/Dockerfile
@@ -13,13 +13,14 @@ RUN set -ex \
     C4F0DFFF4E8C1A8236409D08E73BC641CC11F4C8 \
     B9AE9905FFD7803F25714661B63B535A4C206CA9 \
     56730D5401028683275BD23C23EFEFE93C4CFFFE \
+    77984A986EBC2AA786BC0F66B01FBB92821C587A \
   ; do \
     gpg --keyserver pgp.mit.edu --recv-keys "$key" || \
     gpg --keyserver keyserver.pgp.com --recv-keys "$key" || \
     gpg --keyserver ha.pool.sks-keyservers.net --recv-keys "$key" ; \
   done
 
-ENV NODE_VERSION 8.8.1
+ENV NODE_VERSION 9.0.0
 
 RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \
   && case "${dpkgArch##*-}" in \
diff --git a/node_wheezy/Dockerfile b/node_wheezy/Dockerfile
index 60ad43d..9818cb4 100644
--- a/node_wheezy/Dockerfile
+++ b/node_wheezy/Dockerfile
@@ -13,13 +13,14 @@ RUN set -ex \
     C4F0DFFF4E8C1A8236409D08E73BC641CC11F4C8 \
     B9AE9905FFD7803F25714661B63B535A4C206CA9 \
     56730D5401028683275BD23C23EFEFE93C4CFFFE \
+    77984A986EBC2AA786BC0F66B01FBB92821C587A \
   ; do \
     gpg --keyserver pgp.mit.edu --recv-keys "$key" || \
     gpg --keyserver keyserver.pgp.com --recv-keys "$key" || \
     gpg --keyserver ha.pool.sks-keyservers.net --recv-keys "$key" ; \
   done
 
-ENV NODE_VERSION 8.8.1
+ENV NODE_VERSION 9.0.0
 
 RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \
   && case "${dpkgArch##*-}" in \

This was referenced Nov 1, 2017
Merged
Merged
@knksmith57
Copy link

hey y'all, any way I can help with this?

We're eager to start testing internal apps + packages against carbon and use docker exclusively for CI/CD 😃

thanks!

@tianon
Copy link
Member

tianon commented Nov 1, 2017

Just waiting on the build test that's currently running -- our amd64 servers are being especially slow today. 😞

@PeterDaveHello
Copy link
Contributor Author

Thanks @tianon ! Let me know if I can help anything :)

@tianon
Copy link
Member

tianon commented Nov 1, 2017

I've cheated for now and used arm64v8 instead (hence the smaller coverage), if there are build failures, we'll catch/fix them afterwards. 👍

LGTM

Build test of #3655; 654de5a (node):

$ bashbrew build node:9.0.0
Using bashbrew/cache:6e10522d5dd75a3d49882ab3e3fdc078d2b6be2dd56f77ff027dd93cb1f8aa4a (node:9.0.0)
Tagging node:9.0.0
Tagging node:9.0
Tagging node:9
Tagging node:latest

$ test/run.sh node:9.0.0
testing node:9.0.0
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:9.0.0-alpine
skipping "node:9.0.0-alpine" (due to architecture "arm64v8"; only "amd64" supported)

$ test/run.sh node:9.0.0-alpine
testing node:9.0.0-alpine
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:9.0.0-onbuild
Using bashbrew/cache:8a6397f1a34b8a274b37d1905b0618933e6eca1d950080a84e53b01537b3c35c (node:9.0.0-onbuild)
Tagging node:9.0.0-onbuild
Tagging node:9.0-onbuild
Tagging node:9-onbuild
Tagging node:onbuild

$ test/run.sh node:9.0.0-onbuild
testing node:9.0.0-onbuild
	'override-cmd' [1/1]...passed


$ bashbrew build node:9.0.0-slim
Using bashbrew/cache:62f0680144ade296aa274f94f407aef1a915546c5ce63cb75d4265babc3fe18e (node:9.0.0-slim)
Tagging node:9.0.0-slim
Tagging node:9.0-slim
Tagging node:9-slim
Tagging node:slim

$ test/run.sh node:9.0.0-slim
testing node:9.0.0-slim
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:9.0.0-stretch
Using bashbrew/cache:f59fb246df41a6da6351d9494c3a17c984410cdbf092f67c3a0bd617b83ada52 (node:9.0.0-stretch)
Tagging node:9.0.0-stretch
Tagging node:9.0-stretch
Tagging node:9-stretch
Tagging node:stretch

$ test/run.sh node:9.0.0-stretch
testing node:9.0.0-stretch
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:9.0.0-wheezy
skipping "node:9.0.0-wheezy" (due to architecture "arm64v8"; only "amd64" supported)

$ test/run.sh node:9.0.0-wheezy
testing node:9.0.0-wheezy
	image does not exist!


$ bashbrew build node:8.9.0
Using bashbrew/cache:bc5045b2575c0c4859435adfe8b2198ff13856d58a8255d5c023d94d897b1beb (node:8.9.0)
Tagging node:8.9.0
Tagging node:8.9
Tagging node:8
Tagging node:carbon

$ test/run.sh node:8.9.0
testing node:8.9.0
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:8.9.0-alpine
skipping "node:8.9.0-alpine" (due to architecture "arm64v8"; only "amd64" supported)

$ test/run.sh node:8.9.0-alpine
testing node:8.9.0-alpine
	image does not exist!


$ bashbrew build node:8.9.0-onbuild
Building bashbrew/cache:bf87f67a0db888b9b94f98ca05f4f6db5c07141f495a3e354d4242fe8f561092 (node:8.9.0-onbuild)
Tagging node:8.9.0-onbuild
Tagging node:8.9-onbuild
Tagging node:8-onbuild
Tagging node:carbon-onbuild

$ test/run.sh node:8.9.0-onbuild
testing node:8.9.0-onbuild
	'override-cmd' [1/1]...passed


$ bashbrew build node:8.9.0-slim
Building bashbrew/cache:aa4da7edacc17c8993968915927b7e4a155c9abff042337602fecba4b981df1a (node:8.9.0-slim)
Tagging node:8.9.0-slim
Tagging node:8.9-slim
Tagging node:8-slim
Tagging node:carbon-slim

$ test/run.sh node:8.9.0-slim
testing node:8.9.0-slim
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:8.9.0-stretch
Building bashbrew/cache:2932013d91691e31959e62820c8c858f4b4cfcf0f8e0f4c5334361a5e1dcc588 (node:8.9.0-stretch)
Tagging node:8.9.0-stretch
Tagging node:8.9-stretch
Tagging node:8-stretch
Tagging node:carbon-stretch

$ test/run.sh node:8.9.0-stretch
testing node:8.9.0-stretch
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:8.9.0-wheezy
skipping "node:8.9.0-wheezy" (due to architecture "arm64v8"; only "amd64" supported)

$ test/run.sh node:8.9.0-wheezy
testing node:8.9.0-wheezy
	image does not exist!


$ bashbrew build node:6.11.5
Using bashbrew/cache:461fc653f54a2dd4c012843138159694aa6ca79979aa43997b6ff438b7076c06 (node:6.11.5)
Tagging node:6.11.5
Tagging node:6.11
Tagging node:6
Tagging node:boron

$ test/run.sh node:6.11.5
testing node:6.11.5
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:6.11.5-alpine
skipping "node:6.11.5-alpine" (due to architecture "arm64v8"; only "amd64" supported)

$ test/run.sh node:6.11.5-alpine
testing node:6.11.5-alpine
	image does not exist!


$ bashbrew build node:6.11.5-onbuild
Using bashbrew/cache:dce4c79a59e83a4ff490c0a079bbd39e484e2cd72f68b1adba22338bbefbdebf (node:6.11.5-onbuild)
Tagging node:6.11.5-onbuild
Tagging node:6.11-onbuild
Tagging node:6-onbuild
Tagging node:boron-onbuild

$ test/run.sh node:6.11.5-onbuild
testing node:6.11.5-onbuild
	'override-cmd' [1/1]...passed


$ bashbrew build node:6.11.5-slim
Using bashbrew/cache:bd677dfc846ea3c33964079285e2766811ef09fb1a3c6a42f10e930c415229ee (node:6.11.5-slim)
Tagging node:6.11.5-slim
Tagging node:6.11-slim
Tagging node:6-slim
Tagging node:boron-slim

$ test/run.sh node:6.11.5-slim
testing node:6.11.5-slim
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:6.11.5-stretch
Using bashbrew/cache:e0ee1433d3c6dcee7f12a2079d406cf085397707a2322c06cd0ada083aeecbee (node:6.11.5-stretch)
Tagging node:6.11.5-stretch
Tagging node:6.11-stretch
Tagging node:6-stretch
Tagging node:boron-stretch

$ test/run.sh node:6.11.5-stretch
testing node:6.11.5-stretch
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:6.11.5-wheezy
skipping "node:6.11.5-wheezy" (due to architecture "arm64v8"; only "amd64" supported)

$ test/run.sh node:6.11.5-wheezy
testing node:6.11.5-wheezy
	image does not exist!


$ bashbrew build node:4.8.5
Using bashbrew/cache:820246d6ef3c66ef725e50412e0ab9a3fb99f097a86bc530d7cdfa29a7bda4c5 (node:4.8.5)
Tagging node:4.8.5
Tagging node:4.8
Tagging node:4
Tagging node:argon

$ test/run.sh node:4.8.5
testing node:4.8.5
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:4.8.5-alpine
skipping "node:4.8.5-alpine" (due to architecture "arm64v8"; only "amd64" supported)

$ test/run.sh node:4.8.5-alpine
testing node:4.8.5-alpine
	image does not exist!


$ bashbrew build node:4.8.5-onbuild
Using bashbrew/cache:156d6ed3a1090bdcc205d14d0809510fc94775d9425d89e2009ff823d593dee2 (node:4.8.5-onbuild)
Tagging node:4.8.5-onbuild
Tagging node:4.8-onbuild
Tagging node:4-onbuild
Tagging node:argon-onbuild

$ test/run.sh node:4.8.5-onbuild
testing node:4.8.5-onbuild
	'override-cmd' [1/1]...passed


$ bashbrew build node:4.8.5-slim
Using bashbrew/cache:2852f727264be1fe4df06e9651135c2372a162aad3f402c23b5f31df5f5517f9 (node:4.8.5-slim)
Tagging node:4.8.5-slim
Tagging node:4.8-slim
Tagging node:4-slim
Tagging node:argon-slim

$ test/run.sh node:4.8.5-slim
testing node:4.8.5-slim
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:4.8.5-stretch
Using bashbrew/cache:b23b719691449c21f93ef9dc3474e656ce4555dd5b2984010ee2adb05e6e4674 (node:4.8.5-stretch)
Tagging node:4.8.5-stretch
Tagging node:4.8-stretch
Tagging node:4-stretch
Tagging node:argon-stretch

$ test/run.sh node:4.8.5-stretch
testing node:4.8.5-stretch
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:4.8.5-wheezy
skipping "node:4.8.5-wheezy" (due to architecture "arm64v8"; only "amd64" supported)

$ test/run.sh node:4.8.5-wheezy
testing node:4.8.5-wheezy
	image does not exist!

The following images failed at least one test:

  • node:
    • node:9.0.0-wheezy
    • node:8.9.0-alpine
    • node:8.9.0-wheezy
    • node:6.11.5-alpine
    • node:6.11.5-wheezy
    • node:4.8.5-alpine
    • node:4.8.5-wheezy

@tianon tianon merged commit 9e68f15 into docker-library:master Nov 1, 2017
@PeterDaveHello PeterDaveHello deleted the nodejs-8.9.0 branch November 1, 2017 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
library/node
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PeterDaveHello @tianon @knksmith57 @docker-library-bot