Skip to content

Add Rust to build system #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2024
Merged

Add Rust to build system #20

merged 1 commit into from
Jan 12, 2024

Conversation

LaurentGoderre
Copy link
Member

No description provided.

whalelines
whalelines approved these changes Jan 11, 2024
View reviewed changes
Copy link

@whalelines whalelines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yosifkit
Copy link
Member

I don't think we should add consul. They've deprecated the image (docker-library/docs#2283) and I think it has been long enough that we should probably just delete consul and vault from official-images and docs.

@LaurentGoderre
Copy link
Member Author

Amended to just include Rust

@LaurentGoderre LaurentGoderre changed the title Add Consul and Rust to build system Add Rust to build system Jan 12, 2024
@yosifkit yosifkit merged commit 9c03212 into docker-library:subset Jan 12, 2024
@LaurentGoderre LaurentGoderre deleted the consul-rust branch January 12, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yosifkit yosifkit yosifkit approved these changes

@whalelines whalelines whalelines approved these changes

@tianon tianon Awaiting requested review from tianon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LaurentGoderre @yosifkit @whalelines