Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alpine 3.14 #373

Merged
merged 1 commit into from
Jun 16, 2021
Merged

Alpine 3.14 #373

merged 1 commit into from
Jun 16, 2021

Conversation

techknowlogick
Copy link
Contributor

Fix #372

@techknowlogick techknowlogick mentioned this pull request Jun 16, 2021
Merged
@techknowlogick
Copy link
Contributor Author

CI Fail seems related to #359

@techknowlogick
Copy link
Contributor Author

If anyone wants to take a look at CI fail I'm happy to give access to this branch, probably better if you create a new PR though so you don't need to wait on me for anything.

@tianon
Copy link
Member

tianon commented Jun 16, 2021

Ahahaha, it's the reverse of the problem in #359, I love it. I'll take a look. 👍

@tianon
Copy link
Member

tianon commented Jun 16, 2021

https://github.com/docker-library/golang/compare/68ce3330628f4d0a28a13254d98f5f4275b71c5b..6dd3e33358a28c4d352ec09528e4c77e8c61c235 is removing Alpine 3.12

https://github.com/docker-library/golang/compare/6dd3e33358a28c4d352ec09528e4c77e8c61c235..f300e60ca19c3b98cfcf01ca112af2ac10104320 is the actual fix

The end result is just codifying the two trouble situations -- Go 1.15 built against Go 1.16+ or Go 1.16+ built against Go 1.15 (where Alpine 3.13 represents Go 1.15 for one half of the comparisons).

@tianon tianon requested a review from yosifkit June 16, 2021 21:52
@yosifkit yosifkit merged commit 1373933 into docker-library:master Jun 16, 2021
@techknowlogick techknowlogick deleted the alpine3.14 branch June 16, 2021 22:32
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Jun 16, 2021
@docker-library-bot
Update golang
844e81d 
Changes:

- docker-library/golang@1373933: Merge pull request docker-library/golang#373 from techknowlogick/alpine3.14
- docker-library/golang@f300e60: Update to Alpine 3.14
@yosifkit yosifkit mentioned this pull request Jun 16, 2021
Merged
@DasSkelett DasSkelett mentioned this pull request Jun 18, 2021
Closed
@SamuAlfageme SamuAlfageme mentioned this pull request Jun 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yosifkit yosifkit yosifkit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Alpine 3.14 has now been released
3 participants
@techknowlogick @tianon @yosifkit