re-enable arm32v6 and arm32v7 builds #447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Builds for these architectures were broken for some time, but this should be resolved now, so we can re-enable these (fingers crossed). This reverts commit 461a3ec. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Contributor
Author
Contributor
Author
|
CI looks happy, and I see some |
yosifkit
approved these changes
Sep 28, 2023
Member
yosifkit
left a comment
yosifkit
left a comment
There was a problem hiding this comment.
Successfully built arm32v6 and arm32v7 locally with qemu-user-static and also built arm32v7 on an arm64v8 aws server.
Contributor
Author
|
Thanks for checking! |
Member
|
I tested on an arm32v7 box and they seem OK; my v6 box is less accessible, so it seems pretty reasonable IMO to roll the dice and assume it's fixed. 😄 |
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Sep 29, 2023
Changes: - docker-library/docker@52a2206: Merge pull request docker-library/docker#447 from thaJeztah/reenable_arm32 - docker-library/docker@b0550bb: re-enable arm32v6 and arm32v7 builds
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Oct 2, 2023
Changes: - docker-library/docker@c0e8bf9: Merge pull request docker-library/docker#448 from infosiftr/remove-23 - docker-library/docker@ff78b7b: Remove version 23.x - docker-library/docker@52a2206: Merge pull request docker-library/docker#447 from thaJeztah/reenable_arm32 - docker-library/docker@b0550bb: re-enable arm32v6 and arm32v7 builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds for these architectures were broken for some time, but this should be resolved now, so we can re-enable these (fingers crossed).
This reverts commit 461a3ec.