Skip to content

Fall back to "git fetch ... +SHA:..." (like GitHub Actions do!) if we fail to find the commit #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 6, 2020

Conversation

tianon
Copy link
Member

@tianon tianon commented May 6, 2020

This should allow diff-pr.sh to generate diffs on PRs like docker-library/official-images#7951 (comment) without any usage of the junky old commit-warehouse that's always been a gross hack! 😄 🥳

@yosifkit yosifkit merged commit 0386241 into docker-library:master May 6, 2020
@yosifkit yosifkit deleted the git-fetch-commit branch May 6, 2020 17:27
tianon added a commit to docker-library/official-images that referenced this pull request May 6, 2020
The warehouse is no longer necessary thanks to docker-library/bashbrew#4 🥳
tianon added a commit to docker-library/docs that referenced this pull request May 6, 2020
The warehouse is no longer necessary thanks to docker-library/bashbrew#4 🥳

(This is essentially a revert of 85113cc)
tianon added a commit to docker-library/oi-janky-groovy that referenced this pull request May 6, 2020
The warehouse is no longer necessary thanks to docker-library/bashbrew#4 🥳
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants