Merge pull request moby#40604 from thaJeztah/19.03_backport_mis_unlock

AkihiroSuda · web-flow · commit 71373c6105e3 · 2020-02-29T10:37:35.000+09:00
[19.03 backport] daemon/cluster: add a missing Unlock
diff --git a/daemon/cluster/swarm.go b/daemon/cluster/swarm.go
@@ -33,6 +33,7 @@ func (c *Cluster) Init(req types.InitRequest) (string, error) {
 			// API handlers to finish before shutting down the node.
 			c.mu.Lock()
 			if !c.nr.nodeState.IsManager() {
+				c.mu.Unlock()
 				return "", errSwarmNotManager
 			}
 			c.mu.Unlock()

Original file line number	Diff line number	Diff line change
`@@ -33,6 +33,7 @@ func (c *Cluster) Init(req types.InitRequest) (string, error) {`
`33`	`33`	`// API handlers to finish before shutting down the node.`
`34`	`34`	`c.mu.Lock()`
`35`	`35`	`if !c.nr.nodeState.IsManager() {`
	`36`	`+ c.mu.Unlock()`
`36`	`37`	`return "", errSwarmNotManager`
`37`	`38`	`}`
`38`	`39`	`c.mu.Unlock()`