This repository was archived by the owner on Dec 13, 2018. It is now read-only.
Allow passing hashed HTTP auth credentials #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
May I ask sincerely admins of this repository (@tifayuki, maybe), what do you think about this pull request? We are currently sharing Docker cloud access between more users and it is really unwise to let everyone read unprotected passwords in the environment variables. Thank you for the reply. |
|
Sorry for the late response. |
tifayuki
pushed a commit
that referenced
this pull request
Feb 15, 2017
* Adds option for turning off basic auth for selected services (#154) * Allow a service to be configured as failover for another service in the same backend (#120) * Added support for hot-failover mode * Updated README * Add ability to pass hashed password credentials to HAproxy. (#107) * Remove DHE-RSA-AES128-SHA from SSL_BIND_CIPHERS (#103) * fixed tests error by PRs * do not return haproxy ingress network (#160) * fix the error introduced by EXCLUDE_BASIC_AUTH * bump version
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, an image supports to pass only non-hashed original passwords through the environment variables. This may be quite dangerous if there are more people managing e.g. the Docker Cloud account.
Patch adds functionality for passing HTTP auth credentials with hashed password as well.
Backward compatibility is preserved, hashes are passed using new environment variable. Existing configuration with insecure passwords still applies.
Tests are passing.
PS: I am newbie to Python and would appreciate code style comments.