Skip to content

Commit 998f496

Browse files
csabellaterryjreedy
authored andcommitted
bpo-30617: IDLE: docstrings and unittest for outwin.py (python#2046)
Move some data and functions from the class to module level. Patch by Cheryl Sabella.
1 parent 3457f42 commit 998f496

File tree

3 files changed

+278
-62
lines changed

3 files changed

+278
-62
lines changed

Lib/idlelib/idle_test/test_outwin.py

+172
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,172 @@
1+
""" Test idlelib.outwin.
2+
"""
3+
4+
import unittest
5+
from tkinter import Tk, Text
6+
from idlelib.idle_test.mock_tk import Mbox_func
7+
from idlelib.idle_test.mock_idle import Func
8+
from idlelib import outwin
9+
from test.support import requires
10+
from unittest import mock
11+
12+
13+
class OutputWindowTest(unittest.TestCase):
14+
15+
@classmethod
16+
def setUpClass(cls):
17+
requires('gui')
18+
root = cls.root = Tk()
19+
root.withdraw()
20+
w = cls.window = outwin.OutputWindow(None, None, None, root)
21+
cls.text = w.text = Text(root)
22+
23+
@classmethod
24+
def tearDownClass(cls):
25+
cls.window.close()
26+
del cls.text, cls.window
27+
cls.root.destroy()
28+
del cls.root
29+
30+
def setUp(self):
31+
self.text.delete('1.0', 'end')
32+
33+
def test_ispythonsource(self):
34+
# OutputWindow overrides ispythonsource to always return False.
35+
w = self.window
36+
self.assertFalse(w.ispythonsource('test.txt'))
37+
self.assertFalse(w.ispythonsource(__file__))
38+
39+
def test_window_title(self):
40+
self.assertEqual(self.window.top.title(), 'Output')
41+
42+
def test_maybesave(self):
43+
w = self.window
44+
eq = self.assertEqual
45+
w.get_saved = Func()
46+
47+
w.get_saved.result = False
48+
eq(w.maybesave(), 'no')
49+
eq(w.get_saved.called, 1)
50+
51+
w.get_saved.result = True
52+
eq(w.maybesave(), 'yes')
53+
eq(w.get_saved.called, 2)
54+
del w.get_saved
55+
56+
def test_write(self):
57+
eq = self.assertEqual
58+
delete = self.text.delete
59+
get = self.text.get
60+
write = self.window.write
61+
62+
# Test bytes.
63+
b = b'Test bytes.'
64+
eq(write(b), len(b))
65+
eq(get('1.0', '1.end'), b.decode())
66+
67+
# No new line - insert stays on same line.
68+
delete('1.0', 'end')
69+
test_text = 'test text'
70+
eq(write(test_text), len(test_text))
71+
eq(get('1.0', '1.end'), 'test text')
72+
eq(get('insert linestart', 'insert lineend'), 'test text')
73+
74+
# New line - insert moves to next line.
75+
delete('1.0', 'end')
76+
test_text = 'test text\n'
77+
eq(write(test_text), len(test_text))
78+
eq(get('1.0', '1.end'), 'test text')
79+
eq(get('insert linestart', 'insert lineend'), '')
80+
81+
# Text after new line is tagged for second line of Text widget.
82+
delete('1.0', 'end')
83+
test_text = 'test text\nLine 2'
84+
eq(write(test_text), len(test_text))
85+
eq(get('1.0', '1.end'), 'test text')
86+
eq(get('2.0', '2.end'), 'Line 2')
87+
eq(get('insert linestart', 'insert lineend'), 'Line 2')
88+
89+
# Test tags.
90+
delete('1.0', 'end')
91+
test_text = 'test text\n'
92+
test_text2 = 'Line 2\n'
93+
eq(write(test_text, tags='mytag'), len(test_text))
94+
eq(write(test_text2, tags='secondtag'), len(test_text2))
95+
eq(get('mytag.first', 'mytag.last'), test_text)
96+
eq(get('secondtag.first', 'secondtag.last'), test_text2)
97+
eq(get('1.0', '1.end'), test_text.rstrip('\n'))
98+
eq(get('2.0', '2.end'), test_text2.rstrip('\n'))
99+
100+
def test_writelines(self):
101+
eq = self.assertEqual
102+
get = self.text.get
103+
writelines = self.window.writelines
104+
105+
writelines(('Line 1\n', 'Line 2\n', 'Line 3\n'))
106+
eq(get('1.0', '1.end'), 'Line 1')
107+
eq(get('2.0', '2.end'), 'Line 2')
108+
eq(get('3.0', '3.end'), 'Line 3')
109+
eq(get('insert linestart', 'insert lineend'), '')
110+
111+
def test_goto_file_line(self):
112+
eq = self.assertEqual
113+
w = self.window
114+
text = self.text
115+
116+
w.flist = mock.Mock()
117+
gfl = w.flist.gotofileline = Func()
118+
showerror = w.showerror = Mbox_func()
119+
120+
# No file/line number.
121+
w.write('Not a file line')
122+
self.assertIsNone(w.goto_file_line())
123+
eq(gfl.called, 0)
124+
eq(showerror.title, 'No special line')
125+
126+
# Current file/line number.
127+
w.write(f'{str(__file__)}: 42: spam\n')
128+
w.write(f'{str(__file__)}: 21: spam')
129+
self.assertIsNone(w.goto_file_line())
130+
eq(gfl.args, (str(__file__), 21))
131+
132+
# Previous line has file/line number.
133+
text.delete('1.0', 'end')
134+
w.write(f'{str(__file__)}: 42: spam\n')
135+
w.write('Not a file line')
136+
self.assertIsNone(w.goto_file_line())
137+
eq(gfl.args, (str(__file__), 42))
138+
139+
del w.flist.gotofileline, w.showerror
140+
141+
142+
class ModuleFunctionTest(unittest.TestCase):
143+
144+
@classmethod
145+
def setUp(cls):
146+
outwin.file_line_progs = None
147+
148+
def test_compile_progs(self):
149+
outwin.compile_progs()
150+
for pat, regex in zip(outwin.file_line_pats, outwin.file_line_progs):
151+
self.assertEqual(regex.pattern, pat)
152+
153+
@mock.patch('builtins.open')
154+
def test_file_line_helper(self, mock_open):
155+
flh = outwin.file_line_helper
156+
test_lines = (
157+
(r'foo file "testfile1", line 42, bar', ('testfile1', 42)),
158+
(r'foo testfile2(21) bar', ('testfile2', 21)),
159+
(r' testfile3 : 42: foo bar\n', (' testfile3 ', 42)),
160+
(r'foo testfile4.py :1: ', ('foo testfile4.py ', 1)),
161+
('testfile5: \u19D4\u19D2: ', ('testfile5', 42)),
162+
(r'testfile6: 42', None), # only one `:`
163+
(r'testfile7 42 text', None) # no separators
164+
)
165+
for line, expected_output in test_lines:
166+
self.assertEqual(flh(line), expected_output)
167+
if expected_output:
168+
mock_open.assert_called_with(expected_output[0], 'r')
169+
170+
171+
if __name__ == '__main__':
172+
unittest.main(verbosity=2)

0 commit comments

Comments
 (0)