Skip to content

Commit 23c28c3

Browse files
authored
Delete dataset after each test in DatasetTests. (GoogleCloudPlatform#3767)
1 parent 19bf13b commit 23c28c3

File tree

1 file changed

+20
-17
lines changed

1 file changed

+20
-17
lines changed

healthcare/v1/src/test/java/snippets/healthcare/DatasetTests.java

+20-17
Original file line numberDiff line numberDiff line change
@@ -69,8 +69,8 @@ public void beforeTest() throws IOException {
6969
System.setOut(new PrintStream(bout));
7070

7171
String datasetId = "dataset-" + UUID.randomUUID().toString().replaceAll("-", "_");
72-
datasetName =
73-
String.format("projects/%s/locations/%s/datasets/%s", PROJECT_ID, REGION_ID, datasetId);
72+
String parentName = String.format("projects/%s/locations/%s", PROJECT_ID, REGION_ID);
73+
datasetName = String.format("%s/datasets/%s", parentName, datasetId);
7474

7575
DatasetCreate.datasetCreate(PROJECT_ID, REGION_ID, datasetId);
7676

@@ -79,30 +79,41 @@ public void beforeTest() throws IOException {
7979
}
8080

8181
@After
82-
public void tearDown() {
82+
public void tearDown() throws IOException {
8383
System.setOut(originalOut);
84+
try {
85+
DatasetDelete.datasetDelete(datasetName);
86+
} catch (GoogleJsonResponseException ex) {
87+
// Dataset already deleted, continue.
88+
}
8489
bout.reset();
8590
}
8691

8792
@Test
88-
public void test_DatasetCreate() throws IOException {
89-
String newDatasetName =
90-
String.format("projects/%s/locations/%s/datasets/new-dataset", PROJECT_ID, REGION_ID);
93+
public void test_DatasetCreateDelete() throws IOException {
94+
String newName = "new-dataset";
95+
String newFullName =
96+
String.format("projects/%s/locations/%s/datasets/%s", PROJECT_ID, REGION_ID, newName);
9197
try {
92-
DatasetDelete.datasetDelete(newDatasetName);
98+
DatasetDelete.datasetDelete(newFullName);
9399
} catch (GoogleJsonResponseException gjre) {
94100
// Expected if new-dataset does not exist.
95101
}
96-
DatasetCreate.datasetCreate(PROJECT_ID, REGION_ID, "new-dataset");
102+
DatasetCreate.datasetCreate(PROJECT_ID, REGION_ID, newName);
97103

98104
String output = bout.toString(StandardCharsets.UTF_8);
99105
assertThat(output, containsString("Dataset created."));
106+
bout.reset();
107+
108+
DatasetDelete.datasetDelete(newFullName);
109+
110+
output = bout.toString();
111+
assertThat(output, containsString("Dataset deleted."));
100112
}
101113

102114
@Test
103115
public void test_DatasetGet() throws IOException {
104116
DatasetGet.datasetGet(datasetName);
105-
106117
String output = bout.toString();
107118
assertThat(output, containsString("Dataset retrieved:"));
108119
}
@@ -146,12 +157,4 @@ public void test_DatasetSetIamPolicy() throws IOException {
146157
String output = bout.toString();
147158
assertThat(output, containsString("Dataset policy has been updated: "));
148159
}
149-
150-
@Test
151-
public void test_DatasetDelete() throws IOException {
152-
DatasetDelete.datasetDelete(datasetName);
153-
154-
String output = bout.toString();
155-
assertThat(output, containsString("Dataset deleted."));
156-
}
157160
}

0 commit comments

Comments
 (0)