Skip to content

Commit aba8de4

Browse files
committed
disable databricks and synapse ibis backend tests
1 parent ff54ab6 commit aba8de4

File tree

1 file changed

+13
-10
lines changed

1 file changed

+13
-10
lines changed

dlt/helpers/ibis.py

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
from dlt.destinations.impl.mssql.configuration import MsSqlClientConfiguration
1919
from dlt.destinations.impl.bigquery.configuration import BigQueryClientConfiguration
2020
from dlt.destinations.impl.clickhouse.configuration import ClickHouseClientConfiguration
21-
21+
from dlt.destinations.impl.synapse.configuration import SynapseClientConfiguration
2222

2323
try:
2424
import ibis # type: ignore
@@ -109,11 +109,14 @@ def _ignore_hstore(conn: Any, name: Any) -> Any:
109109
con = ibis.snowflake.connect(
110110
schema=dataset_name, **sn_credentials, create_object_udfs=False
111111
)
112-
elif issubclass(destination.spec, MsSqlClientConfiguration):
112+
elif issubclass(destination.spec, MsSqlClientConfiguration) and not issubclass(
113+
destination.spec, SynapseClientConfiguration
114+
):
113115
from dlt.destinations.impl.mssql.mssql import MsSqlJobClient
114116

115117
assert isinstance(client, MsSqlJobClient)
116118
ms_credentials = client.config.credentials.to_native_representation()
119+
ms_credentials = ms_credentials.replace("synapse://", "mssql://")
117120
con = ibis.connect(ms_credentials, driver=client.config.credentials.driver)
118121
elif issubclass(destination.spec, BigQueryClientConfiguration):
119122
from dlt.destinations.impl.bigquery.bigquery import BigQueryClient
@@ -139,14 +142,14 @@ def _ignore_hstore(conn: Any, name: Any) -> Any:
139142
secure=bool(ch_client.config.credentials.secure),
140143
# compression=True,
141144
)
142-
elif issubclass(destination.spec, DatabricksClientConfiguration):
143-
from dlt.destinations.impl.databricks.databricks import DatabricksClient
144-
145-
bricks_client = cast(DatabricksClient, client)
146-
con = ibis.databricks.connect(
147-
**bricks_client.config.credentials.to_connector_params(),
148-
schema=bricks_client.sql_client.dataset_name,
149-
)
145+
# elif issubclass(destination.spec, DatabricksClientConfiguration):
146+
# from dlt.destinations.impl.databricks.databricks import DatabricksClient
147+
148+
# bricks_client = cast(DatabricksClient, client)
149+
# con = ibis.databricks.connect(
150+
# **bricks_client.config.credentials.to_connector_params(),
151+
# schema=bricks_client.sql_client.dataset_name,
152+
# )
150153
elif issubclass(destination.spec, AthenaClientConfiguration):
151154
from dlt.destinations.impl.athena.athena import AthenaClient
152155

0 commit comments

Comments
 (0)