Skip to content

Commit 84de711

Browse files
sh-rprudolfix
andauthored
Re-enable python 3.14 common tests (#3242)
* enable python 3.14 * try on mac * remove beta 4 disclaimer * adds sleep before starting windows e2e tests --------- Co-authored-by: Marcin Rudolf <rudolfix@rudolfix.org>
1 parent 76823c3 commit 84de711

File tree

3 files changed

+15
-14
lines changed

3 files changed

+15
-14
lines changed

.github/workflows/test_common.yml

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,9 @@ jobs:
4343
python-version: "3.13"
4444
shell: bash
4545

46-
# - os: ubuntu-latest
47-
# python-version: "3.14.0-beta.4"
48-
# shell: bash
46+
- os: "macos-14"
47+
python-version: "3.14"
48+
shell: bash
4949

5050
# linux test with minimal dependencies
5151
- os: ubuntu-latest
@@ -114,40 +114,40 @@ jobs:
114114
115115
- name: Install pyarrow
116116
run: uv sync ${{ matrix.uv_sync_args }} --extra duckdb --extra cli --extra parquet --group sentry-sdk
117-
if: matrix.python-version != '3.14.0-beta.4'
117+
if: matrix.python-version != '3.14'
118118

119119
- name: Run pipeline tests with pyarrow but no pandas installed
120120
run: |
121121
pytest tests/pipeline/test_pipeline_extra.py -k arrow ${{ matrix.pytest_args }}
122-
if: matrix.python-version != '3.14.0-beta.4'
122+
if: matrix.python-version != '3.14'
123123

124124
- name: Install workspace dependencies
125125
run: uv sync ${{ matrix.uv_sync_args }} --extra workspace --extra cli --group sentry-sdk
126-
if: matrix.python-version != '3.14.0-beta.4'
126+
if: matrix.python-version != '3.14'
127127

128128
- name: Run workspace tests
129129
run: |
130130
pytest tests/workspace ${{ matrix.pytest_args }}
131-
if: matrix.python-version != '3.14.0-beta.4'
131+
if: matrix.python-version != '3.14'
132132

133133
- name: Install pipeline and sources dependencies
134134
run: uv sync ${{ matrix.uv_sync_args }} --extra http --extra duckdb --extra cli --extra parquet --extra deltalake --extra sql_database --group sentry-sdk --group pipeline --group sources --group ibis
135-
if: matrix.python-version != '3.14.0-beta.4'
135+
if: matrix.python-version != '3.14'
136136

137137
- name: Run extract and pipeline tests
138138
run: |
139139
pytest tests/extract tests/pipeline tests/libs tests/destinations tests/sources ${{ matrix.pytest_args }}
140-
if: matrix.python-version != '3.14.0-beta.4'
140+
if: matrix.python-version != '3.14'
141141

142142
# here we upgrade sql alchemy to 2 an run the sql_database tests again
143143
- name: Upgrade sql alchemy
144144
run: uv run pip install sqlalchemy==2.0.32
145-
if: matrix.python-version != '3.14.0-beta.4'
145+
if: matrix.python-version != '3.14'
146146

147147
- name: Run extract and pipeline tests
148148
run: |
149149
pytest tests/sources/sql_database
150-
if: matrix.python-version != '3.14.0-beta.4'
150+
if: matrix.python-version != '3.14'
151151
matrix_job_required_check:
152152
name: common | common tests
153153
needs: run_common

.github/workflows/test_tools_dashboard.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,16 +104,17 @@ jobs:
104104
run: |
105105
pytest tests/workspace/helpers/dashboard
106106
107-
# Run pipeline dashboard e2e tests (does not pass with python 3.9, does not pass on windows (playwright does not work somehow), does not pass on python 3.13 (ibis not available))
108-
# Mac is also disabled for the time being
107+
# Run pipeline dashboard e2e tests (does not pass with python 3.9
109108
- name: Run dashboard e2e
110109
run: |
111110
marimo run --headless dlt/_workspace/helpers/dashboard/dlt_dashboard.py -- -- --pipelines-dir _storage/.dlt/pipelines/ --with_test_identifiers true & pytest --browser chromium tests/e2e
112111
if: matrix.python-version != '3.9' && matrix.python-version != '3.14.0-beta.4' && matrix.os != 'windows-latest'
113112

113+
# note that this test will pass only when running from cmd shell (_storage\.dlt\pipelines\ must stay)
114114
- name: Run dashboard e2e windows
115115
run: |
116116
start marimo run --headless dlt/_workspace/helpers/dashboard/dlt_dashboard.py -- -- --pipelines-dir _storage\.dlt\pipelines\ --with_test_identifiers true
117+
timeout /t 2 /nobreak >NUL
117118
pytest --browser chromium tests/e2e
118119
if: matrix.python-version != '3.9' && matrix.python-version != '3.14.0-beta.4' && matrix.os == 'windows-latest'
119120

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ Be it a Google Colab notebook, AWS Lambda function, an Airflow DAG, your local l
3131

3232
## Installation
3333

34-
dlt supports Python 3.9 through Python 3.14 (beta 4). Note that some optional extras are not yet available for Python 3.14, so support for this version is considered experimental.
34+
dlt supports Python 3.9 through Python 3.14. Note that some optional extras are not yet available for Python 3.14, so support for this version is considered experimental.
3535

3636
```sh
3737
pip install dlt

0 commit comments

Comments
 (0)