Test test_import_destination_type_config

Author: anuunchin

tests/common/destination/test_reference.py

@@ -308,6 +308,48 @@ def test_import_destination_config() -> None:
         Destination.from_reference(ref=None, destination_name="balh")
 
 
+@pytest.mark.parametrize(
+    "destination_type",
+    ["duckdb", "wrong_type"],
+    ids=["destination_type_duckdb", "destination_type_invalid"],
+)
+def test_import_destination_type_config(
+    environment: Dict[str, str],
+    destination_type: str,
+    destination_name: str = "my_destination",
+) -> None:
+    environment[f"DESTINATION__{destination_name.upper()}__DESTINATION_TYPE"] = destination_type
+
+    if destination_type == "wrong_type":
+        with pytest.raises(UnknownDestinationModule):
+            Destination.from_reference(ref=destination_name)
+
+        # if destination_name is provided, ref should be a valid destination type
+        with pytest.raises(UnknownDestinationModule):
+            Destination.from_reference(
+                ref=f"dlt.destinations.{destination_type}", destination_name=destination_name
+            )
+
+        # if ref contains dots, it's a module path and should be valid
+        with pytest.raises(UnknownDestinationModule):
+            Destination.from_reference(ref=f"dlt.destinations.{destination_type}")
+
+    else:
+        dest = Destination.from_reference(ref=destination_name)
+        assert dest.destination_type == "dlt.destinations.duckdb"
+        assert dest.destination_name == destination_name
+
+        dest = Destination.from_reference(
+            ref=f"dlt.destinations.{destination_type}", destination_name=destination_name
+        )
+        assert dest.destination_type == "dlt.destinations.duckdb"
+        assert dest.destination_name == destination_name
+
+        dest = Destination.from_reference(ref=f"dlt.destinations.{destination_type}")
+        assert dest.destination_type == "dlt.destinations.duckdb"
+        assert dest.destination_name == "duckdb"
+
+
 def test_destination_config_explicit_credentials() -> None:
     # set explicit credentials via reference
     dest = Destination.from_reference(