Additional test adjustments

Author: anuunchin

docs/website/docs/dlt-ecosystem/destinations/destination.md

@@ -127,35 +127,31 @@ There are multiple ways to pass the custom destination function to the `dlt` pip
   p = dlt.pipeline("my_pipe", destination=my_destination(api_key=os.getenv("API_KEY"))) # type: ignore[call-arg]
   ```
 
-- Directly via destination reference. In this case, don't use the decorator for the destination function.
+- Via the function that initializes the destination. In this case, don't use the decorator for the destination function.
   ```py
   # File my_destination.py
 
-  from dlt.common.destination import Destination
-
   # Don't use the decorator
   def local_destination_func(items: TDataItems, table: TTableSchema) -> None:
       ...
 
-  # Via destination reference
+  # Via the function that initializes the destination
   p = dlt.pipeline(
       "my_pipe",
-      destination=Destination.from_reference(
-          "destination", destination_callable=local_destination_func
+      destination=dlt.destination(
+          "my_destination", destination_callable=local_destination_func
       )
   )
   ```
 - Via a fully qualified string to function location (this can be set in `config.toml` or through environment variables). The destination function should be located in another file.
   ```py
   # File my_pipeline.py
 
-  from dlt.common.destination import Destination
-
   # Fully qualified string to function location
   p = dlt.pipeline(
       "my_pipe",
-      destination=Destination.from_reference(
-          "destination", destination_callable="my_destination.local_destination_func"
+      destination=dlt.destination(
+          "my_destination", destination_callable="my_destination.local_destination_func"
       )
   )
   ```

docs/website/docs/general-usage/destination.md

@@ -116,6 +116,7 @@ To configure multiple destinations within a pipeline, you need to provide the cr
 
 ```toml
 [destination.destination_one]
+destination_type = "bigquery"
 location = "US"
 [destination.destination_one.credentials]
 project_id = "please set me up!"
@@ -126,15 +127,11 @@ client_email = "please set me up!"
 You can then use this destination in your pipeline as follows:
 ```py
 import dlt
-from dlt.common.destination import Destination
 
 # Configure the pipeline to use the "destination_one" BigQuery destination
 pipeline = dlt.pipeline(
     pipeline_name='pipeline',
-    destination=Destination.from_reference(
-        "bigquery",
-        destination_name="destination_one"
-    ),
+    destination=dlt.destination("destination_one"),
     dataset_name='dataset_name'
 )
 ```

tests/load/duckdb/test_duckdb_client.py

@@ -307,7 +307,12 @@ def test_credentials_wrong_config() -> None:
 
 
 @pytest.mark.no_load
-def test_duckdb_in_memory_mode_via_factory():
+@pytest.mark.parametrize(
+    "use_dest_decorator",
+    [True, False],
+    ids=["using_dest_decorator", "without_using_dest_decorator"],
+)
+def test_duckdb_in_memory_mode_via_factory(use_dest_decorator: bool):
     import duckdb
 
     # Check if passing external duckdb connection works fine
@@ -334,9 +339,12 @@ def test_duckdb_in_memory_mode_via_factory():
     assert isinstance(exc.value.exception, InvalidInMemoryDuckdbCredentials)
 
     with pytest.raises(PipelineStepFailed) as exc:
+        # NOTE: using dlt.destination as factory initializer and Destination.from_reference
+        # should behave the same
+        dest_ref_func = dlt.destination if use_dest_decorator else Destination.from_reference
         p = dlt.pipeline(
             pipeline_name="booboo",
-            destination=Destination.from_reference("duckdb", credentials=":memory:"),
+            destination=dest_ref_func("duckdb", credentials=":memory:"),
         )
         p.run([1, 2, 3], table_name="numbers")
 

tests/load/pipeline/test_postgres.py

@@ -58,20 +58,30 @@ def test_postgres_encoded_binary(
 
 # do not remove - it allows us to filter tests by destination
 @pytest.mark.no_load
+@pytest.mark.parametrize(
+    "use_dest_decorator",
+    [True, False],
+    ids=["using_dest_decorator", "without_using_dest_decorator"],
+)
 @pytest.mark.parametrize(
     "destination_config",
     destinations_configs(default_sql_configs=True, subset=["postgres"]),
     ids=lambda x: x.name,
 )
 def test_pipeline_explicit_destination_credentials(
+    use_dest_decorator: bool,
     destination_config: DestinationTestConfiguration,
 ) -> None:
     from dlt.destinations import postgres
     from dlt.destinations.impl.postgres.configuration import PostgresCredentials
 
+    # NOTE: using dlt.destination as factory initializer and Destination.from_reference
+    # should behave the same
+    dest_ref_func = dlt.destination if use_dest_decorator else Destination.from_reference
+
     # explicit credentials resolved
     p = dlt.pipeline(
-        destination=Destination.from_reference(
+        destination=dest_ref_func(
             "postgres",
             destination_name="mydest",
             credentials="postgresql://loader:loader@localhost:7777/dlt_data",
@@ -84,7 +94,7 @@ def test_pipeline_explicit_destination_credentials(
     # explicit credentials resolved ignoring the config providers
     os.environ["DESTINATION__MYDEST__CREDENTIALS__HOST"] = "HOST"
     p = dlt.pipeline(
-        destination=Destination.from_reference(
+        destination=dest_ref_func(
             "postgres",
             destination_name="mydest",
             credentials="postgresql://loader:loader@localhost:5432/dlt_data",
@@ -97,7 +107,7 @@ def test_pipeline_explicit_destination_credentials(
     os.environ["DESTINATION__MYDEST__CREDENTIALS__USERNAME"] = "UN"
     os.environ["DESTINATION__MYDEST__CREDENTIALS__PASSWORD"] = "PW"
     p = dlt.pipeline(
-        destination=Destination.from_reference(
+        destination=dest_ref_func(
             "postgres",
             destination_name="mydest",
             credentials="postgresql://localhost:5432/dlt_data",

tests/pipeline/test_pipeline_state.py

@@ -16,7 +16,6 @@
 from dlt.common.storages import FileStorage
 from dlt.common.storages.load_package import TPipelineStateDoc
 from dlt.common.utils import uniq_id
-from dlt.common.destination import Destination
 from dlt.common.destination.client import StateInfo
 from dlt.common.validation import validate_dict
 
@@ -103,8 +102,8 @@ def test_state_repr() -> None:
 def test_restore_state_props() -> None:
     p = dlt.pipeline(
         pipeline_name="restore_state_props",
-        destination=Destination.from_reference("redshift", destination_name="redshift_name"),
-        staging=Destination.from_reference("filesystem", destination_name="filesystem_name"),
+        destination=dlt.destination("redshift_name", destination_type="redshift"),
+        staging=dlt.destination("filesystem_name", destination_type="filesystem"),
         dataset_name="the_dataset",
     )
     print(get_dlt_pipelines_dir())