Skip to content

Commit 1853d41

Browse files
committed
Bug fix. Wrong count() if groupBy using in query
1 parent e369732 commit 1853d41

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

src/Chumper/Datatable/Engines/QueryEngine.php

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,9 @@ public function totalCount()
7373
$originalBuilder = $this->removeGroupBy($originalBuilder);
7474
}
7575

76-
return $originalBuilder->count();
76+
return \DB::table(\DB::raw('('.$originalBuilder->toSql().') as temp_tbl'))
77+
->mergeBindings($originalBuilder->getQuery())
78+
->count();
7779
}
7880

7981
public function getArray()
@@ -126,7 +128,9 @@ protected function internalMake(Collection $columns, array $searchColumns = arra
126128
if ($this->options['noGroupByOnCount']) {
127129
$countBuilder = $this->removeGroupBy($countBuilder);
128130
}
129-
$this->options['counter'] = $countBuilder->count();
131+
$this->options['counter'] = \DB::table(\DB::raw('('.$countBuilder->toSql().') as temp_tbl'))
132+
->mergeBindings($countBuilder->getQuery())
133+
->count();
130134
}
131135

132136
$builder = $this->doInternalOrder($builder, $columns);

0 commit comments

Comments
 (0)