Fix ImageFormat equality comparison#1668
Merged
dlemstra merged 1 commit intodlemstra:mainfrom Jul 4, 2024
Merged
Conversation
|
|
dlemstra
approved these changes
Jul 4, 2024
Owner
dlemstra
left a comment
dlemstra
left a comment
There was a problem hiding this comment.
Thanks for fixing this. I think I will follow this up with small improvement.
This was referenced Jul 23, 2025
This was referenced Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When working with serialized images, e.g. embedded resources in WinForms, the equality check of the extension method fails. When deserializing the image, a new instance of
ImageFormatis created, which still uses the sameGuidas the singleton instance, but represents a whole new instance, thus failing the equality check.