fix: add guards for MagickImage.BilateralBlur#1545
Merged
dlemstra merged 4 commits intodlemstra:mainfrom Feb 9, 2024
Merged
Conversation
Owner
|
In your other PR you used |
Contributor
Author
|
PR Updated according to your requests 🙂 |
dlemstra
reviewed
Feb 9, 2024
| Throw.IfFalse(nameof(width), width > 1, "The width must be > 1"); | ||
| Throw.IfFalse(nameof(height), height > 1, "The height must be > 1"); | ||
| Throw.IfNegative(nameof(width), width); | ||
| Throw.IfNegative(nameof(height), height); |
Owner
There was a problem hiding this comment.
Could you add a newline after the Thow's? I do that in the rest of the library.
p.s. I missed that in your other pr...
dlemstra
approved these changes
Feb 9, 2024
This was referenced Jul 23, 2025
This was referenced Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋
size_tforwitdh&height; some lines later, they are bounded to 1 at minimumMagick.NET/src/Magick.NET/Native/MagickImage.cs
Lines 4157 to 4182 in 6035129
Same could be done for
intensitySigma&spatialSigma, but ImageMagick always multiply each param by itself, making them always positive.On one hand, it's already "safe".
On the other hand, there is nothing (at least comments) telling it must be
> 0.Regards.
Edit: added the exception tag that was missing (even without my modifications)