Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Issue 21801 - std.typecons.ReplaceType does not work for in parameters #7937

Merged
merged 1 commit into from
Apr 15, 2021

Conversation

JohanEngelen
Copy link
Contributor

See related: #7570

@JohanEngelen JohanEngelen requested a review from MetaLang as a code owner April 5, 2021 19:54
@dlang-bot
Copy link
Contributor

dlang-bot commented Apr 5, 2021

Thanks for your pull request and interest in making D better, @JohanEngelen! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
21801 major std.typecons.ReplaceType does not work for in parameters

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + phobos#7937"

@Geod24
Copy link
Member

Geod24 commented Apr 6, 2021

Stable ?

@JohanEngelen
Copy link
Contributor Author

don't know the exact dev policy. Feel free to retarget to stable.

@Geod24 Geod24 changed the base branch from master to stable April 6, 2021 23:19
@Geod24
Copy link
Member

Geod24 commented Apr 6, 2021

For trivial bug fixes it's better to target stable. It also means your fix will be available with the next LDC release, since Kinke usually release new minors based on the latest patch release.

@JohanEngelen
Copy link
Contributor Author

CI is apparently broken for stable branch?

@RazvanN7
Copy link
Collaborator

RazvanN7 commented Apr 8, 2021

Has there been a rebase screw-up? The bot thinks that this PR is fixing 7 issues.

@JohanEngelen
Copy link
Contributor Author

I don't know what the bot thinks, but looks like everything is OK, just one commit on top of stable. (I've done everything through the webinterface). Thanks a lot for merging :)

@berni44
Copy link
Contributor

berni44 commented Apr 12, 2021

Strange thing here. I'm getting the same failures like the failing tests, when running the tests with dmd from master instead of dmd from stable. Don't know if this helps to track down the problem...

@JohanEngelen
Copy link
Contributor Author

Strange thing here. I'm getting the same failures like the failing tests, when running the tests with dmd from master instead of dmd from stable. Don't know if this helps to track down the problem...

The CI errors are completely unrelated to this PR.

@JohanEngelen JohanEngelen changed the base branch from stable to master April 12, 2021 20:38
@JohanEngelen JohanEngelen changed the base branch from master to stable April 12, 2021 20:42
@JohanEngelen
Copy link
Contributor Author

#7958

@thewilsonator
Copy link
Contributor

merged, please rebase.

@JohanEngelen
Copy link
Contributor Author

rebased

@dlang-bot dlang-bot merged commit b8cdef5 into dlang:stable Apr 15, 2021
@JohanEngelen JohanEngelen deleted the patch-2 branch April 15, 2021 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants