Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable curl tests for FreeBSD 32-bit #6232

Merged
merged 1 commit into from
Feb 28, 2018

Conversation

wilzbach
Copy link
Member

See also: braddr/d-tester#70 (comment)

I'm aware that this isn't ideal and StdUnittest would be better suited for this, but it keeps the diff small and std.net.curl is broken on FreeBSD 32-bit anyhow.
Moreover, I have the opinion that we should just drop the support for legacy platforms that almost no one actively uses, but well that's a different story.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@JackStouffer
Copy link
Member

Does this issue effect the beta? If so, we should make a final decision about what to do before it's released.

@wilzbach wilzbach changed the base branch from master to stable February 28, 2018 03:26
@wilzbach
Copy link
Member Author

Does this issue effect the beta? If so, we should make a final decision about what to do before it's released.

std.net.curl is broken on FreeBSD 32-bit for on anything newer than FreeBSD 8. FreeBSD 9 was released in 2012 and support for FreeBSD 8 ended in 2015.
So as far as I can judge, it doesn't change the status quo at all, but I think it makes merging easier if I target stable and then merge it back to master.

BTW looking at the auto-tester report I see that somehow FreeBSD 32-bit didn't get started for this PR.
CC @braddr

@wilzbach
Copy link
Member Author

The workaround at dmd was targeted at master, not stable. So stable is still broken. Going to rebase this again to master then ...

@wilzbach wilzbach changed the base branch from stable to master February 28, 2018 17:48
@dlang-bot dlang-bot merged commit fdb9022 into dlang:master Feb 28, 2018
@wilzbach wilzbach deleted the disable-curl-freebsd-32 branch March 11, 2018 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants