replace binary literals with hex #4779
Conversation
| out_ = 2, /// ditto | ||
| ref_ = 4, /// ditto | ||
| lazy_ = 8, /// ditto | ||
| return_ = 0x10, /// ditto |
There was a problem hiding this comment.
I like the consistency of style and alignment in the original.
Can this be:
0x01,
0x02,
0x04,
0x08,
0x10,There was a problem hiding this comment.
I used to do things that way, but over time changed to the method used in the PR. The visual noise just makes it take that much longer for my brain to process. Having leading 0's is not appealing.
There was a problem hiding this comment.
Over time, I've also come to the conclusion that the binary literal syntax is just a mistake. Hex is much easier to grok (don't have to put a pencil on the screen and count positions). Ironically, other languages are starting to adopt it :-) so I'm out of step as usual.
There was a problem hiding this comment.
It doesn't need to have leading zeros. Another possibility would be:
1,
2,
4,
8,
0x10,What I like about the alignment is when you compare what bit positions are set from multiple values, they are easier to compare.
I also think the binary is quite useless, and prefer hex. It took me a while when I started, but learning what all the hex values are is not that bad.
There was a problem hiding this comment.
And of course, the placement of the _ in the original was atrocious. It should ONLY ever be put on byte or nibble boundaries.
|
Auto-merge toggled on |
Binary literals are borderline illegible, especially with the weird _ placement. Use hex values like everywhere else.